Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 32108: Fix a tiny bug with SigningFetcher.php in php shindig (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by panjie.pan
Modified:
16 years, 6 months ago
Reviewers:
panjie, chabotc1
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

Here are what I did in the patch: 1. there is a bug when signed fetch a get request. postParams is null and this line of code will report a warning: $msgParams = array_merge($msgParams, $postParams); 2. added an unittest for signed fetch post request with header "Content-Type:application/json" 3. modified verification process in SigningFetcherTest.php.

Patch Set 1 #

Patch Set 2 : updated. add base64_encode after sha1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
php/src/gadgets/SigningFetcher.php View 1 1 chunk +2 lines, -2 lines 0 comments Download
php/test/gadgets/SigningFetcherTest.php View 1 1 chunk +25 lines, -2 lines 0 comments Download

Messages

Total messages: 2
panjie.pan
16 years, 10 months ago (2009-04-02 08:33:34 UTC) #1
panjie.pan
16 years, 10 months ago (2009-04-02 10:23:08 UTC) #2
updated. add base64_encode after sha1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b