Issue 3210041: code review 3210041: gc: skip undefined symbols in import .

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3210041: code review 3210041: gc: skip undefined symbols in import . (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by ejsherry

Modified:
14 years, 3 months ago

Reviewers:

CC:
ken3, rsc, golang-dev

Visibility:
Public.

Description

gc: skip undefined symbols in import . Fixes issue 1284.

Patch Set 1 #

Patch Set 2 : code review 3210041: gc: skip undefined names in import . #

Patch Set 3 : code review 3210041: gc: skip undefined symbols in import . #

Patch Set 4 : code review 3210041: gc: skip undefined symbols in import . #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -0 lines)			Patch
M	src/cmd/gc/subr.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug313.go	View	2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug313.dir/a.go	View	2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug313.dir/b.go	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

ejsherry

Hello ken3, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-11-19 01:46:24 UTC) #1

rsc

please use errchk (grep for it in the other bug files) to avoid having to ...

14 years, 3 months ago (2010-11-19 03:33:19 UTC) #2

ejsherry

On 18 November 2010 19:33, Russ Cox <rsc@golang.org> wrote: > please use errchk (grep for ...

14 years, 3 months ago (2010-11-19 04:05:58 UTC) #3

ejsherry

On 2010/12/07 18:03:11, rsc wrote: > assuming you'll update this once we fix errchk Done. ...

14 years, 3 months ago (2010-12-07 21:09:01 UTC) #5

rsc

14 years, 3 months ago (2010-12-07 21:16:04 UTC) #7

*** Submitted as b065b0392c96 ***

gc: skip undefined symbols in import .

Fixes issue 1284.

R=ken3, rsc
CC=golang-dev
http://codereview.appspot.com/3210041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages