Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 32080: [issue2578] additional unittest type equality methods

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by gregory.p.smith
Modified:
10 years, 5 months ago
Reviewers:
GvR, fuzzyman
CC:
report_bugs.python.org
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/
Visibility:
Public.

Description

http://bugs.python.org/issue2578 - additional unittest type specific equality methods that print useful error messages and type introspection within assertEqual to automatically use them when deemed appropriate.

Patch Set 1 #

Patch Set 2 : whoops, fixed some accidental lowercasing of a section of the documentation (vi error :). #

Patch Set 3 : minor cleanup #

Total comments: 26

Patch Set 4 : no new plural Equals and the context manager is now private. #

Patch Set 5 : fix test_gc #

Patch Set 6 : move assertFalse before failIf in the docs #

Patch Set 7 : final version to be committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1079 lines, -90 lines) Patch
M Doc/library/unittest.rst View 1 2 3 4 5 6 8 chunks +205 lines, -21 lines 0 comments Download
M Lib/test/test_gc.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Lib/test/test_struct.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Lib/test/test_unittest.py View 1 2 3 4 5 6 7 chunks +417 lines, -47 lines 0 comments Download
M Lib/unittest.py View 1 2 3 4 5 6 8 chunks +446 lines, -21 lines 0 comments Download
M Misc/NEWS View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
GvR
Hi Greg, I've mostly reviewed for style... http://codereview.appspot.com/32080/diff/13/1006 File Doc/library/unittest.rst (right): http://codereview.appspot.com/32080/diff/13/1006#newcode611 Line 611: assertTrue(expr[, ...
10 years, 5 months ago (2009-03-31 15:01:06 UTC) #1
gregory.p.smith
http://codereview.appspot.com/32080/diff/13/1006 File Doc/library/unittest.rst (right): http://codereview.appspot.com/32080/diff/13/1006#newcode611 Line 611: assertTrue(expr[, msg]) On 2009/03/31 15:01:06, GvR wrote: > ...
10 years, 5 months ago (2009-03-31 16:37:02 UTC) #2
GvR
10 years, 5 months ago (2009-03-31 16:41:34 UTC) #3
LG.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b