Make ibus emojier dialog as an unique application

Make ibus emojier dialog as an unique application

Because wayland doesn't support clipboard persistence, just hide the dialog; will show the emojier dialog again, when run it again.

In next patches, ibus emoji command will just spawn the process of ibus-ui-emojier.

BUG=

[Peng Wu, 2017-04-01 02:52:26]

Please review it, thanks!

[fujiwara, 2017-04-03 08:01:41]

Thank you for creating the patch.
It works fine with me.

Probably I will delete libibus-emoji-dialog*.so*, ibus-emoji-dialog-1.0.vapi,
ibusemojidialog.h later since the new interface ibus-ui-emojier is provided.

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/Makefile.am
File ui/gtk3/Makefile.am (right):

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/Makefile.am#newcode136
ui/gtk3/Makefile.am:136: if ENABLE_UI
ENABLE_UI is not needed since ibus/Makefile.am uses it.

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/Makefile.am#newcode147
ui/gtk3/Makefile.am:147: emojier_app.vala \
I think emojierapp.vala is the better filename than emojier_app.vala to follow
other vala filenames.

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala
File ui/gtk3/emojier_app.vala (right):

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:29: private EmojiApplication () {
s/EmojiApplication ()/EmojiApplication()/

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:30: Object (application_id:
"org.freedesktop.ibus.panel.emojier",
s/Object (/Object(/

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:32: set_inactivity_timeout (100000);
s/set_inactivity_timeout (100000)/set_inactivity_timeout(100000)/

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:44: print("%s\n", _("Canceled to choose an emoji."));
Do you have any ideas to show this message with the second instance too and
`ibus emoji` command also show the message?

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:54: public override void activate () {
s/activate ()/activate()/

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:55: stdout.puts ("activated\n");
This message is not needed?

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:76: stdout.puts ("command line.\n");
This message is not needed?

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:82: N_("LANG for annotations on emoji dialog. E.g.
\"en\""), "LANG" },
Please make 3 lines from 2 lines since the line overs 80 columns:
  { "font", 0, 0, OptionArg.STRING, out emoji_font,
    N_("FONT for emoji chracters on emoji dialog."),
    "FONT" },
  { "lang", 0, 0, OptionArg.STRING, out annotation_lang,
    N_("LANG for annotations on emoji dialog. E.g. \"en\""),
    "LANG" },

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:90: // that it can remove strings from the array
without freeing them.
Please keep 80 columns per line.

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:122: activate ();
s/activate ()/activate()/

https://codereview.appspot.com/320450043/diff/1/ui/gtk3/emojier_app.vala#newc...
ui/gtk3/emojier_app.vala:136: GLib.Intl.setlocale(GLib.LocaleCategory.ALL, "");
setlocale() is called by gtk_init()?

[Peng Wu, 2017-04-06 07:51:59]

Please review it again, thanks!

[fujiwara, 2017-04-06 13:46:16]

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala
File ui/gtk3/emojierapp.vala (right):

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:1: /* vim:set et sts=4 sw=4:
Seems you don't set vim modelines.
Could you change Tab to 4 spaces?

[fujiwara, 2017-04-07 03:43:37]

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala
File ui/gtk3/emojierapp.vala (right):

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:44: command_line.print("%s\n", _("Canceled to choose an
emoji."));
Please keep 80 columns per line.

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:62: // The signal is called when the language is
changed.
Please keep 80 columns per line.

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:90: string[] args = command_line.get_arguments ();
s/command_line.get_arguments ()/command_line.get_arguments()/

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:127: // keep the application running until we are done
with this commandline
Please keep 80 columns per line.

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:128: this.hold ();
s/this.hold ();/this.hold();/

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:129: int result = _command_line (command_line);
s/_command_line (command_line)/_command_line(command_line)/

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:130: this.release ();
s/this.release ()/this.release()/

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:135: GLib.Intl.bindtextdomain(Config.GETTEXT_PACKAGE,
Config.GLIB_LOCALE_DIR);
Please keep 80 columns per line.

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:143: EmojiApplication app = new EmojiApplication ();
s/new EmojiApplication ()/new EmojiApplication()/

https://codereview.appspot.com/320450043/diff/20001/ui/gtk3/emojierapp.vala#n...
ui/gtk3/emojierapp.vala:144: int status = app.run (args);
s/app.run (args);/app.run(args);/

[Peng Wu, 2017-04-07 05:50:57]

Please review it again, thanks!

[fujiwara, 2017-04-07 07:02:54]

On 2017/04/07 05:50:57, Peng Wu wrote:
> Please review it again, thanks!

lgtm

[Peng, 2017-04-07 08:29:23]

On 2017/04/07 07:02:54, fujiwara wrote:
> On 2017/04/07 05:50:57, Peng Wu wrote:
> > Please review it again, thanks!
> 
> lgtm

lgtm

[fujiwara, 2017-04-07 09:21:04]

I missed one thing.
Also could you update po/POTFILES.in and po/POTFILES.skip ?

https://codereview.appspot.com/320450043/diff/40001/ui/gtk3/Makefile.am
File ui/gtk3/Makefile.am (right):

https://codereview.appspot.com/320450043/diff/40001/ui/gtk3/Makefile.am#newco...
ui/gtk3/Makefile.am:109: libexec_PROGRAMS = ibus-ui-gtk3 ibus-ui-emojier
This should be moved into if ENABLE_EMOJI_DICT otherwise the build failure:

if ENABLE_EMOJI_DICT
libexec_PROGRAMS += ibus-ui-emojier
endif

[Peng Wu, 2017-04-10 04:52:03]

Please review it again, thanks!

[fujiwara, 2017-04-10 05:59:28]

Committed.
Could you please close this issue?
Thank you for the patch.
I think it's better to make git log comments within 80 columns next time.

[Peng Wu, 2017-04-10 06:34:36]

Okay, closed.