Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(379)

Issue 32041: <os:Repeat>, <os:If> and special var precedence support + unit tests; Optimized My; @context -> @cur

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by levik
Modified:
10 years, 5 months ago
Reviewers:
opensocial.evan, shindig-remailer, awiner
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

- JSTemplate brought in as a copy, modified to allow proper functioning of @cur - @cur needs to be explicitly passed to custom tags - Cur -> My -> Top precedence - Tag-based control structures - unit tests

Patch Set 1 #

Total comments: 5

Patch Set 2 : Added Apache headers in JST files, changed os:renderAll -> os:Render in test file #

Messages

Total messages: 1
Evan Gilbert (code review)
16 years, 1 month ago (2009-04-01 20:20:14 UTC) #1
http://codereview.appspot.com/32041/diff/1/7
File
features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js
(right):

http://codereview.appspot.com/32041/diff/1/7#newcode1
Line 1: // Copyright 2006 Google Inc.
Need standard Apache headers here, plus standard Apache coding style.

Is it possible to include this as a Maven dependency? Not sure what we're
modifying, but possibly we can monkey-patch in the different functions.

http://codereview.appspot.com/32041/diff/1/6
File
features/src/main/javascript/features/opensocial-templates/jsTemplate/jstemplate.js
(right):

http://codereview.appspot.com/32041/diff/1/6#newcode1
Line 1: // Copyright 2006 Google Inc.
Need standard apache headers, etc.

http://codereview.appspot.com/32041/diff/1/8
File
features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js
(right):

http://codereview.appspot.com/32041/diff/1/8#newcode1
Line 1: // Copyright 2006 Google Inc.
Standard apache headers, etc.

http://codereview.appspot.com/32041/diff/1/2
File features/src/test/javascript/features/opensocial-templates/template_test.js
(right):

http://codereview.appspot.com/32041/diff/1/2#newcode484
Line 484: tryTemplateContent('<div><span
repeat="My.Word"><os:renderAll/></span></div>');
Should we switch these to <os:Render>?

http://codereview.appspot.com/32041/diff/1/2#newcode746
Line 746: tryTemplateContent('<os:msg Value="Wrong" cur="${Top}"/>', { Value:
'Right' } );
Do we want to change these to reflect cur not propagating downward? This can be
a followup issue, as it was a recent change.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b