Issue 319480043: src: Update emoji-parser to treat tts as emoji description

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 319480043: src: Update emoji-parser to treat tts as emoji description (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by fujiwara

Modified:
7 years, 3 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, maiku.fabian

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

src: Update emoji-parser to treat tts as emoji description unicode annotation xml files have a 'tts' attribute and seem it is used as the emoji descriptions instead of emoji annotations. This can show the translated descriptions. R=Shawn.P.Huang@gmail.com Committed: fbe3de1789c73a8a175a451b2a6b967f5d3c6514

Patch Set 1 #

Patch Set 2 : Updated with the latest master #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -13 lines)			Patch
M	src/emoji-parser.c	View	1	5 chunks	+19 lines, -7 lines	0 comments	Download
M	src/ibusemoji.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/ibusemoji.c	View	1	4 chunks	+13 lines, -3 lines	0 comments	Download
M	ui/gtk3/emojier.vala	View	1	3 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

On 2017/03/10 13:08:52, fujiwara wrote: > CC'ing maiku.fabian lgtm

7 years, 3 months ago (2017-03-10 15:15:03 UTC) #3

fujiwara

7 years, 3 months ago (2017-03-13 03:08:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
fbe3de1789c73a8a175a451b2a6b967f5d3c6514 (presubmit successful).

Expand All Messages | Collapse All Messages