Issue 319470043: ui/gtk3: Get emoji colors from the theme

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 319470043: ui/gtk3: Get emoji colors from the theme (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by fujiwara

Modified:
7 years, 3 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Get emoji colors from the theme Get selected and normal text color from the theme. Implement to activate an emoji with mouse motion. Create back button on emoji language chooser dialog. Set row_homogeneous on emoji table. R=Shawn.P.Huang@gmail.com Committed: 9dbea347050ae2ad79d1b53f2ad62a7a2cafadc6

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+251 lines, -130 lines)			Patch
M	ui/gtk3/Makefile.am	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/gtk3/candidatearea.vala	View	5 chunks	+110 lines, -76 lines	0 comments	Download
M	ui/gtk3/emojier.vala	View	23 chunks	+138 lines, -54 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 3 months ago (2017-03-09 03:45:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9dbea347050ae2ad79d1b53f2ad62a7a2cafadc6 (presubmit successful).

Expand All Messages | Collapse All Messages