Issue 3192042: Clean up the code of focus switch logic, and fix a crash when focused context is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3192042: Clean up the code of focus switch logic, and fix a crash when focused context is destroyed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by Peng Huang

Modified:
15 years, 3 months ago

Reviewers:
Yusuke Sato, satorux

Base URL:
git@github.com:/ibus/ibus.git@master

Visibility:
Public.

Description

Clean up the code of focus switch logic, and fix a crash when focused context is destroyed. BUG=none TEST=manual

Patch Set 1 #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -82 lines)			Patch
	M	bus/ibusimpl.c	View		4 chunks	+64 lines, -81 lines	0 comments	Download
	M	bus/inputcontext.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Yusuke Sato

LGTM, but I have two requests: 1. please add a comment to explain how to ...

15 years, 3 months ago (2010-11-24 01:56:20 UTC) #3

Peng Huang

On 2010/11/24 01:56:20, Yusuke Sato wrote: > LGTM, but I have two requests: > > ...

15 years, 3 months ago (2010-11-24 02:06:48 UTC) #4

Peng Huang

On 2010/11/24 01:56:20, Yusuke Sato wrote: > LGTM, but I have two requests: > > ...

15 years, 3 months ago (2010-11-24 02:07:43 UTC) #5

Yusuke Sato

15 years, 3 months ago (2010-11-24 02:16:15 UTC) #6

I see, thanks!

On Wed, Nov 24, 2010 at 11:06 AM, <penghuang@chromium.org> wrote:

> On 2010/11/24 01:56:20, Yusuke Sato wrote:
>
>> LGTM, but I have two requests:
>>
>
>  1. please add a comment to explain how to reproduce the crash.
>> 2. if the crash could also reproduce in ibus-1.3, please file a bug on
>> http://crosbug.com/.
>>
>
> The crash only happens in ibus-1.4. I think it is involved by a commit
>
> https://github.com/ibus/ibus/commit/5e823fcbff6b29286babc99e783d13af7ba505b3
>
> .
>
>
> http://codereview.appspot.com/3192042/
>

Expand All Messages | Collapse All Messages