Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2416)

Issue 319150043: Issue 3830: Document \offset command

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by david.nalesnik
Modified:
2 years, 8 months ago
Reviewers:
pkx166h, thomasmorley651, simon.albrecht, t.daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3830: Document \offset command

Patch Set 1 #

Total comments: 20

Patch Set 2 : Be more expansive #

Patch Set 3 : Improve wording, add slashes #

Patch Set 4 : Clarify criteria/examples #

Patch Set 5 : diagram syntax, other improvements #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -0 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 2 3 4 2 chunks +312 lines, -0 lines 2 comments Download

Messages

Total messages: 17
david.nalesnik
Please review. Thanks!
2 years, 9 months ago (2017-01-23 00:04:26 UTC) #1
simon.albrecht
LGTM.
2 years, 9 months ago (2017-01-23 08:26:06 UTC) #2
thomasmorley651
Two thoughts, otherwise LGTM https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522 Documentation/notation/changing-defaults.itely:2522: [-]\offset @var{property} @var{offsets} @var{item} Would ...
2 years, 8 months ago (2017-01-23 23:52:54 UTC) #3
david.nalesnik
https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522 Documentation/notation/changing-defaults.itely:2522: [-]\offset @var{property} @var{offsets} @var{item} On 2017/01/23 23:52:54, thomasmorley651 wrote: ...
2 years, 8 months ago (2017-01-24 13:34:27 UTC) #4
pkx166h
David, Thanks for doing this - I know how hard it is to add a ...
2 years, 8 months ago (2017-01-24 14:36:09 UTC) #5
david.nalesnik
Thanks so such for the detailed review! Will post a patch update in the near ...
2 years, 8 months ago (2017-01-24 16:09:02 UTC) #6
david.nalesnik
Be more expansive
2 years, 8 months ago (2017-01-24 22:30:41 UTC) #7
david.nalesnik
I've posted an extensive rewrite which hopefully addresses all the concerns. I think the result ...
2 years, 8 months ago (2017-01-24 22:38:21 UTC) #8
david.nalesnik
Question: How do I get a backslash in @subsubsubheading{} ? The literal symbol doesn't show ...
2 years, 8 months ago (2017-01-24 22:57:55 UTC) #9
t.daniels_treda.co.uk
david.nalesnik@gmail.com wrote Tuesday, January 24, 2017 10:57 PM > Question: > > How do I ...
2 years, 8 months ago (2017-01-24 23:32:51 UTC) #10
david.nalesnik
On 2017/01/24 23:32:51, t.daniels_treda.co.uk wrote: > mailto:david.nalesnik@gmail.com wrote Tuesday, January 24, 2017 10:57 PM > ...
2 years, 8 months ago (2017-01-24 23:48:57 UTC) #11
david.nalesnik
Improve wording, add slashes
2 years, 8 months ago (2017-01-25 02:28:39 UTC) #12
david.nalesnik
Clarify criteria/examples
2 years, 8 months ago (2017-01-25 16:16:14 UTC) #13
david.nalesnik
diagram syntax, other improvements
2 years, 8 months ago (2017-01-25 20:43:23 UTC) #14
david.nalesnik
On 2017/01/25 20:43:23, david.nalesnik wrote: > diagram syntax, other improvements This is as clear as ...
2 years, 8 months ago (2017-01-25 20:47:23 UTC) #15
simon.albrecht
One typo did I spot :-) https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely#newcode2777 Documentation/notation/changing-defaults.itely:2777: The @code{\offset} command ...
2 years, 8 months ago (2017-01-25 22:33:33 UTC) #16
david.nalesnik
2 years, 8 months ago (2017-01-26 14:33:18 UTC) #17
https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/ch...
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/ch...
Documentation/notation/changing-defaults.itely:2777: The @code{\offset} command
used in this manner is similiar to the
On 2017/01/25 22:33:32, simon.albrecht wrote:
> s/similiar/similar

Yup--thanks.  Will bundle that with whatever changes may come.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b