Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3618)

Issue 318640043: Add 'ibus emoji' command for no ibus panel desktops (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by fujiwara
Modified:
7 years, 3 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Add 'ibus emoji' command for no ibus panel desktops This utility can be used on GNOME desktop which shows a gnome-shell icon instead of running ibus-ui-gtk3. R=Shawn.P.Huang@gmail.com Committed: c37989acffed8dc66a95deb8b113ac7a1d84e6ee

Patch Set 1 #

Patch Set 2 : Fixed typo #

Patch Set 3 : Updated for master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -38 lines) Patch
M Makefile.am View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/Makefile.am View 3 chunks +24 lines, -1 line 0 comments Download
M tools/main.vala View 1 3 chunks +41 lines, -0 lines 0 comments Download
A ui/gtk3/IBusEmojiDialog-1.0.metadata View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gtk3/Makefile.am View 3 chunks +101 lines, -13 lines 0 comments Download
M ui/gtk3/emojier.vala View 1 10 chunks +27 lines, -13 lines 0 comments Download
A ui/gtk3/ibus-emoji-dialog-1.0.deps View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/gtk3/ibusemojidialog.h View 1 chunk +153 lines, -0 lines 0 comments Download
M ui/gtk3/panel.vala View 1 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3
fujiwara
7 years, 3 months ago (2017-03-05 09:23:36 UTC) #1
Peng
On 2017/03/05 09:23:36, fujiwara wrote: lgtm
7 years, 3 months ago (2017-03-05 16:34:41 UTC) #2
fujiwara
7 years, 3 months ago (2017-03-06 09:14:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c37989acffed8dc66a95deb8b113ac7a1d84e6ee (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b