Issue 317990043: ticket:12869: Don't use ordinal() to define public constants.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 317990043: ticket:12869: Don't use ordinal() to define public constants. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 11 months ago by roubert (google)

Modified:
7 years, 11 months ago

Reviewers:
sffc

Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk

Visibility:
Public.

ticket:12869: Don't use ordinal() to define public constants. Committed: http://bugs.icu-project.org/trac/changeset/39525

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	icu4j/main/classes/core/src/com/ibm/icu/impl/CurrencyData.java	View		2 chunks	+10 lines, -1 line	0 comments	Download
	M	icu4j/main/classes/core/src/com/ibm/icu/text/DecimalFormatSymbols.java	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Total messages: 3

roubert (google)

Do you think this is a good solution, or do you have some other proposal?

7 years, 11 months ago (2016-12-01 12:06:27 UTC) #1

roubert (google)

Committed patchset #1 (id:1) manually as 39525 (presubmit successful).

7 years, 11 months ago (2016-12-05 20:49:41 UTC) #2

sffc

7 years, 11 months ago (2016-12-05 21:06:33 UTC) #3

Message was sent while issue was closed.

On 2016/12/05 20:49:41, roubert (google) wrote:
> Committed patchset #1 (id:1) manually as 39525 (presubmit successful).

LGTM