Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(498)

Issue 3175041: Small enhancements to RewriteModule to make it reusable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by gagan.goku
Modified:
15 years, 3 months ago
Reviewers:
henry.saputra, dev, anupama.dutta, cool-shindig-committers
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This cl: 1) Makes RewritePath class public (I missed it in http://codereview.appspot.com/2058042/) 2) Makes some of the helper methods of RewriteModule protected so other classes that extend RewriteModule can reuse these.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java View 1 chunk +4 lines, -3 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewritePath.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
anupama.dutta
LGTM. Please send out to dev@, johnfargo and zhoresh.
15 years, 3 months ago (2010-11-17 20:29:23 UTC) #1
gagan.goku
Thanks for the quick response. Sent out to dev, fargo and zhoresh On Thu, Nov ...
15 years, 3 months ago (2010-11-17 20:33:00 UTC) #2
henry.saputra
LGTM (I was curious about the RewritePath not being public)
15 years, 3 months ago (2010-11-17 20:36:54 UTC) #3
gagan.goku
I was in a hurry to submit :) On Thu, Nov 18, 2010 at 2:06 ...
15 years, 3 months ago (2010-11-17 20:38:58 UTC) #4
gagan.goku
15 years, 3 months ago (2010-11-17 20:47:52 UTC) #5
Build looks good.
Committed as r1036219.

Thanks for the quick reviews guys.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b