Move emoji implementation from IBusEngineSimple to IBusPanel

Move emoji implementation from IBusEngineSimple to IBusPanel

Currently emoji shortcut key is not customizable and there is
no menu item to access emoji typing without shortcut key.
Once implementation is moved to IBusPanel, the emoji typing is
now avaible for every engine without modifying its codes.

R=Shawn.P.Huang@gmail.com

Committed: 02d99aa00cb4a26a2cfb6098ea27e763e9bb2daa

[fujiwara, 2017-03-02 12:50:07]

This uses https://github.com/fujiwarat/cldr-annotations

[Peng, 2017-03-02 21:02:35]

https://codereview.appspot.com/317370043/diff/1/src/Makefile.am
File src/Makefile.am (right):

https://codereview.appspot.com/317370043/diff/1/src/Makefile.am#newcode104
src/Makefile.am:104: ibusemoji.c             \
Probably we could sort those files in alphabetical order.

https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c
File src/emoji-parser.c (right):

https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c#newcode210
src/emoji-parser.c:210: GSList      **llist)
llist -> list? what does llist mean?

https://codereview.appspot.com/317370043/diff/1/src/ibusemoji.h
File src/ibusemoji.h (right):

https://codereview.appspot.com/317370043/diff/1/src/ibusemoji.h#newcode163
src/ibusemoji.h:163: * Deprecated: This function has been deprecated and should
Sine you are adding new APIs, should we avoid adding those deprecated APIs?

https://codereview.appspot.com/317370043/diff/1/ui/gtk3/emojier.vala
File ui/gtk3/emojier.vala (right):

https://codereview.appspot.com/317370043/diff/1/ui/gtk3/emojier.vala#newcode195
ui/gtk3/emojier.vala:195: events : Gdk.EventMask.KEY_PRESS_MASK | 
Gdk.EventMask.KEY_RELEASE_MASK | Gdk.EventMask.BUTTON_PRESS_MASK,
Can we short it to fit in 80 chars?

[fujiwara, 2017-03-03 12:28:33]

https://codereview.appspot.com/317370043/diff/1/src/Makefile.am
File src/Makefile.am (right):

https://codereview.appspot.com/317370043/diff/1/src/Makefile.am#newcode104
src/Makefile.am:104: ibusemoji.c             \
On 2017/03/02 21:02:35, Peng wrote:
> Probably we could sort those files in alphabetical order.

Done.

https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c
File src/emoji-parser.c (right):

https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c#newcode210
src/emoji-parser.c:210: GSList      **llist)
On 2017/03/02 21:02:35, Peng wrote:
> llist -> list? what does llist mean?

I meant pointer of list. How about llist -> plist?

https://codereview.appspot.com/317370043/diff/1/src/ibusemoji.h
File src/ibusemoji.h (right):

https://codereview.appspot.com/317370043/diff/1/src/ibusemoji.h#newcode163
src/ibusemoji.h:163: * Deprecated: This function has been deprecated and should
On 2017/03/02 21:02:35, Peng wrote:
> Sine you are adding new APIs, should we avoid adding those deprecated APIs?

Actually the API is moved from ibusutils.h to ibusemoji.h so it already exists.
To support Gir and Vala and includes other info; description, category; I
changed the dict format and the existent API is no longer useful.
I modified those APIs again to be worked.
Probably I guess the APIs are not deleted since ibusutil.h is public?

https://codereview.appspot.com/317370043/diff/1/ui/gtk3/emojier.vala
File ui/gtk3/emojier.vala (right):

https://codereview.appspot.com/317370043/diff/1/ui/gtk3/emojier.vala#newcode195
ui/gtk3/emojier.vala:195: events : Gdk.EventMask.KEY_PRESS_MASK | 
Gdk.EventMask.KEY_RELEASE_MASK | Gdk.EventMask.BUTTON_PRESS_MASK,
On 2017/03/02 21:02:35, Peng wrote:
> Can we short it to fit in 80 chars?

Done.

[Peng, 2017-03-03 15:20:18]

https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c
File src/emoji-parser.c (right):

https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c#newcode210
src/emoji-parser.c:210: GSList      **llist)
On 2017/03/03 12:28:33, fujiwara wrote:
> On 2017/03/02 21:02:35, Peng wrote:
> > llist -> list? what does llist mean?
> 
> I meant pointer of list. How about llist -> plist?
I think just list is fine. For example we just use GError **error instead of
perror. And what about gtk and glib, how do they name pointer of pointer?

https://codereview.appspot.com/317370043/diff/1/src/ibusemoji.h
File src/ibusemoji.h (right):

https://codereview.appspot.com/317370043/diff/1/src/ibusemoji.h#newcode163
src/ibusemoji.h:163: * Deprecated: This function has been deprecated and should
On 2017/03/03 12:28:33, fujiwara wrote:
> On 2017/03/02 21:02:35, Peng wrote:
> > Sine you are adding new APIs, should we avoid adding those deprecated APIs?
> 
> Actually the API is moved from ibusutils.h to ibusemoji.h so it already
exists.
> To support Gir and Vala and includes other info; description, category; I
> changed the dict format and the existent API is no longer useful.
> I modified those APIs again to be worked.
> Probably I guess the APIs are not deleted since ibusutil.h is public?

Acknowledged.

[fujiwara, 2017-03-03 19:56:46]

https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c
File src/emoji-parser.c (right):

https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c#newcode210
src/emoji-parser.c:210: GSList      **llist)
On 2017/03/03 15:20:18, Peng wrote:
> On 2017/03/03 12:28:33, fujiwara wrote:
> > On 2017/03/02 21:02:35, Peng wrote:
> > > llist -> list? what does llist mean?
> > 
> > I meant pointer of list. How about llist -> plist?
> I think just list is fine. For example we just use GError **error instead of
> perror. And what about gtk and glib, how do they name pointer of pointer?

Agreed. Done.

[Peng, 2017-03-03 20:10:14]

On 2017/03/03 19:56:46, fujiwara wrote:
> https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c
> File src/emoji-parser.c (right):
> 
> https://codereview.appspot.com/317370043/diff/1/src/emoji-parser.c#newcode210
> src/emoji-parser.c:210: GSList      **llist)
> On 2017/03/03 15:20:18, Peng wrote:
> > On 2017/03/03 12:28:33, fujiwara wrote:
> > > On 2017/03/02 21:02:35, Peng wrote:
> > > > llist -> list? what does llist mean?
> > > 
> > > I meant pointer of list. How about llist -> plist?
> > I think just list is fine. For example we just use GError **error instead of
> > perror. And what about gtk and glib, how do they name pointer of pointer?
> 
> Agreed. Done.

lgtm

[fujiwara, 2017-03-05 09:11:39]

Committed patchset #4 (id:60001) manually as
02d99aa00cb4a26a2cfb6098ea27e763e9bb2daa (presubmit successful).