Issue 316420043: src: Enable unicode_alt in EmojiOne json file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 316420043: src: Enable unicode_alt in EmojiOne json file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 2 months ago by fujiwara

Modified:
7 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

src: Enable unicode_alt in EmojiOne json file EmojiOne json file has unicode_alt property which includes emoji modifer characters. Committed: cb0a36c254dc7a96b2a984e715f96cc2ec32e2d5

Patch Set 2 : Updated with comment #2 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -10 lines)			Patch
M	src/emoji-parser.c	View		6 chunks	+17 lines, -3 lines	0 comments	Download
M	src/ibusemoji.h	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/ibusemoji.c	View		10 chunks	+44 lines, -4 lines	0 comments	Download
M	ui/gtk3/emojier.vala	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/316420043/diff/1/ui/gtk3/emojier.vala File ui/gtk3/emojier.vala (right): https://codereview.appspot.com/316420043/diff/1/ui/gtk3/emojier.vala#newcode385 ui/gtk3/emojier.vala:385: string emoji_alternates = data.get_emoji_alternates(); emoji = data.get_emoji_alternates() or ...

7 years, 2 months ago (2017-03-31 12:04:42 UTC) #2

fujiwara

https://codereview.appspot.com/316420043/diff/1/ui/gtk3/emojier.vala File ui/gtk3/emojier.vala (right): https://codereview.appspot.com/316420043/diff/1/ui/gtk3/emojier.vala#newcode385 ui/gtk3/emojier.vala:385: string emoji_alternates = data.get_emoji_alternates(); On 2017/03/31 12:04:42, Peng wrote: ...

7 years, 2 months ago (2017-04-03 03:23:32 UTC) #3

fujiwara

7 years, 2 months ago (2017-04-03 03:24:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cb0a36c254dc7a96b2a984e715f96cc2ec32e2d5 (presubmit successful).

Expand All Messages | Collapse All Messages