Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(224)

Issue 315700043: ui/gtk3: Implement shortcut keys on emoji dialog (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by fujiwara
Modified:
9 years, 3 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Implement shortcut keys on emoji dialog - Implement Ctrl-f, Ctrl-b, Ctrl-n, Ctrl-p, Ctrl-h, Ctrh-e for cursor movements; forward, back, next, previous, head, end on emoji grid. - Implement Ctrl-a and Shift+arrow for text selection on emoji annotation. - Implement Ctrl-u to delete text on emoji annotation. - Implement to delete a selected text on emoji annotation. - Change to show page indices to candidate indices on emoji. - Sorted emoji categories. - Added timeout of m_enter_notify_enable = false to bring back mouse. R=Shawn.P.Huang@gmail.com Committed: 58f6140f427815adc947a5bb5c7dea4f3e315ae8

Patch Set 1 #

Patch Set 2 : Fix a typo. #

Patch Set 3 : Updated with the latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -96 lines) Patch
M ui/gtk3/emojier.vala View 1 14 chunks +215 lines, -96 lines 0 comments Download

Messages

Total messages: 3
fujiwara
9 years, 3 months ago (2017-03-14 09:48:39 UTC) #1
Peng
On 2017/03/14 09:48:39, fujiwara wrote: lgtm
9 years, 3 months ago (2017-03-14 10:36:00 UTC) #2
fujiwara
9 years, 3 months ago (2017-03-15 02:52:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
58f6140f427815adc947a5bb5c7dea4f3e315ae8 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b