Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2576)

Issue 315410043: Web: Review GSoC page introduction

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by git
Modified:
2 years, 8 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Web: Review GSoC page introduction

Patch Set 1 #

Patch Set 2 : Add a "general recommendations" section #

Patch Set 3 : Fixing embarrassing syntax errors (hopefully) #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -19 lines) Patch
M Documentation/web/community.itexi View 1 2 2 chunks +94 lines, -19 lines 2 comments Download

Messages

Total messages: 5
git
Add a "general recommendations" section
2 years, 8 months ago (2017-01-23 19:17:20 UTC) #1
git
Fixing embarrassing syntax errors (hopefully)
2 years, 8 months ago (2017-01-30 14:20:55 UTC) #2
dak
https://codereview.appspot.com/315410043/diff/40001/Documentation/web/community.itexi File Documentation/web/community.itexi (right): https://codereview.appspot.com/315410043/diff/40001/Documentation/web/community.itexi#newcode952 Documentation/web/community.itexi:952: @subheading Adopt the SMuFL music font encoding standard Uh, ...
2 years, 8 months ago (2017-01-30 15:08:46 UTC) #3
git
https://codereview.appspot.com/315410043/diff/40001/Documentation/web/community.itexi File Documentation/web/community.itexi (right): https://codereview.appspot.com/315410043/diff/40001/Documentation/web/community.itexi#newcode952 Documentation/web/community.itexi:952: @subheading Adopt the SMuFL music font encoding standard On ...
2 years, 8 months ago (2017-01-30 16:17:02 UTC) #4
dak
2 years, 8 months ago (2017-01-30 16:21:29 UTC) #5
git@ursliska.de writes:

>
https://codereview.appspot.com/315410043/diff/40001/Documentation/web/communi...
> File Documentation/web/community.itexi (right):
>
>
https://codereview.appspot.com/315410043/diff/40001/Documentation/web/communi...
> Documentation/web/community.itexi:952: @subheading Adopt the SMuFL music
> font encoding standard
> On 2017/01/30 15:08:45, dak wrote:
>> Uh, that's not exactly what I would call "fixing embarrassing syntax
> errors".
>> It is a complete new paragraph.
>
>> Though it's not clear to me how this diff comes about: this appears to
> be
>> already in LilyPond proper anyway.
>
> I'm not sure what you're concretely referring to here.
> In the line the link pointed to (comparing base to patch set 3 There
> isn't anything in the diff.
>
> You will see that SMuFL project paragraph as new when you compare Patch
> set 2 with patch set 3.

Which is what I did.

> This is due to the fact that patch set 2 was uploaded before I could
> push #5037.

Ok.

> https://codereview.appspot.com/315410043/

-- 
David Kastrup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b