Issue 31500043: freebsd: unbreak build after r16646

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 31500043: freebsd: unbreak build after r16646 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by ben4

Modified:
11 years ago

Reviewers:
dcarney, svenpanne

CC:
v8-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

freebsd: unbreak build after r16646

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/platform-freebsd.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

svenpanne

On 2013/11/25 08:11:29, svenpanne wrote: > LGTM, landing... Can you please close this issue? I ...

11 years ago (2013-11-25 08:15:20 UTC) #3

ben4

11 years ago (2013-11-25 10:31:48 UTC) #4

Message was sent while issue was closed.

On 2013/11/25 08:15:20, svenpanne wrote:
> On 2013/11/25 08:11:29, svenpanne wrote:
> > LGTM, landing...
> 
> Can you please close this issue? I had to duplicate the issue into the correct
> issue tracker...

Closed, thanks.  And sorry about that, upload.py all of a sudden decided to
upload to here rather than codereview.chromium.org...

Expand All Messages | Collapse All Messages