Issue 314640043: ui/gtk3: Enable strcasecmp to match emoji annotation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 314640043: ui/gtk3: Enable strcasecmp to match emoji annotation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by fujiwara

Modified:
7 years, 3 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Enable strcasecmp to match emoji annotation Users can type capital annotations. Also shows emoji annotations in the status bar if the typing unicode point matches a emoji character. Committed: 50e344afaffc29e626dbc27747a1aeee6cccafdf

Patch Set 1 #

Total comments: 4

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -32 lines)			Patch
	M	ui/gtk3/emojier.vala	View		9 chunks	+65 lines, -32 lines	4 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/314640043/diff/1/ui/gtk3/emojier.vala File ui/gtk3/emojier.vala (right): https://codereview.appspot.com/314640043/diff/1/ui/gtk3/emojier.vala#newcode435 ui/gtk3/emojier.vala:435: private string utf8_down(string str) { Add a comment ...

7 years, 3 months ago (2017-03-16 14:31:07 UTC) #2

fujiwara

7 years, 3 months ago (2017-03-17 03:09:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
50e344afaffc29e626dbc27747a1aeee6cccafdf (presubmit successful).

Expand All Messages | Collapse All Messages