Issue 3146042: Changing mapBinder variable to protected for reuse in subclasses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3146042: Changing mapBinder variable to protected for reuse in subclasses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by gagan.goku

Modified:
15 years, 3 months ago

Reviewers:
dev, plindner1

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Another small nit missing in previous submit: http://codereview.appspot.com/3175041/

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

anupama.dutta

LGTM. It will be good to mention the small nit in the CL title and ...

15 years, 3 months ago (2010-11-18 06:38:32 UTC) #1

gagan.goku

15 years, 3 months ago (2010-11-19 02:43:28 UTC) #3

On 2010/11/18 17:04:29, plindner1 wrote:
> lgtm

Build looks good. Committed as r1036714.
Thanks for the reviews guys.