https://codereview.appspot.com/314530043/diff/1/Documentation/css/lilypond-website.css File Documentation/css/lilypond-website.css (right): https://codereview.appspot.com/314530043/diff/1/Documentation/css/lilypond-website.css#newcode709 Documentation/css/lilypond-website.css:709: font-size: 1.17em; what else does this change on the ...
8 years, 2 months ago
(2017-02-22 19:01:52 UTC)
#3
Sorry, I disagree. I think the boxes make it easier to skim the page; there ...
8 years, 2 months ago
(2017-02-22 19:04:46 UTC)
#4
Sorry, I disagree. I think the boxes make it easier to skim the page; there
horizontal gap makes it absolutely clear that each proposal is distinct.
I have no opinion about using bold vs. italics for the "difficulty",
"requirements", etc. parts, though.
On 2017/02/22 19:01:52, Graham Percival wrote: > what else does this change on the webpage? ...
8 years, 2 months ago
(2017-02-22 19:07:15 UTC)
#5
On 2017/02/22 19:01:52, Graham Percival wrote:
> what else does this change on the webpage? I mean, don't we use @subheading
> anywhere else?
On that note, I wrote a tool for my job that does regression testing for a
website (very similar to our lilypond regression tests). I'll try to polish it
and get my boss to OK open-sourcing it in the next few days.
This will help future CSS development by giving us confidence that there's no
unintended changes.
Cheers,
- Graham
On 02/22/2017 02:07 PM, graham@percival-music.ca wrote: > On that note, I wrote a tool for ...
8 years, 2 months ago
(2017-02-23 03:36:20 UTC)
#6
On 02/22/2017 02:07 PM, graham@percival-music.ca wrote:
> On that note, I wrote a tool for my job that does regression testing for
> a website (very similar to our lilypond regression tests). I'll try to
> polish it and get my boss to OK open-sourcing it in the next few days.
>
> This will help future CSS development by giving us confidence that
> there's no unintended changes.
Nice! That sounds great.
-Paul
Sorry for the delay. My tool isn't public yet (hopefully tomorrow or Tuesday), but I ...
8 years, 2 months ago
(2017-03-06 07:14:04 UTC)
#8
Sorry for the delay. My tool isn't public yet (hopefully tomorrow or Tuesday),
but I just ran it on the lilypond website and it looks fine.
This change LGTM.
On 2017/03/15 02:44:17, pwm wrote: > Only change appearance of GSOC project ideas I've rebased ...
8 years, 1 month ago
(2017-03-15 02:49:10 UTC)
#10
On 2017/03/15 02:44:17, pwm wrote:
> Only change appearance of GSOC project ideas
I've rebased this now that issue 5085 landed (which changed some text on the
GSOC page). Also, I looked at the other pages that were affected by the CSS
changes in patch set 1, and did not like the results. So patch set 2 only
changes the appearance of the GSOC project ideas, leaving the rest of the site
unchanged.
-Paul
Issue 314530043: Web: nest GSOC project ideas under subsection/h3
(Closed)
Created 8 years, 2 months ago by pwm
Modified 7 years, 11 months ago
Reviewers: git, Graham Percival, paul_paulwmorris.com, pkx166h
Base URL:
Comments: 1