Made changes to JPEGOptimizer to respect the config parameter jpegConversionAllowed

Made changes to JPEGOptimizer to respect the config parameter jpegConversionAllowed 

Small refactoring changes to BasicImageRewriter, for extending it's functionality.

[gagan.goku, 2010-11-17 04:59:54]

As discussed, please put the conversion to PNG in JPEGOptimizer.rewriteImpl()
behind the jpegConversionAllowed flag

[satya3656, 2010-11-17 13:31:10]

Made the changes as discussed, can you have one more look.

[gagan.goku, 2010-11-17 17:39:53]

looking good, small nits

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java
(right):

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java:62:
int pngLength = Integer.MAX_VALUE;
make it -1 or -2 for better redundancy. minLength has much lesser probability of
being negative that it has of being equal to Integer.MAX_VALUE

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java
(right):

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:42:
public void testSmallJPEGToPNGWithJpegConversionDisabled() throws Exception {
could you also add a test case that shows that when jpegConversion is enabled,
small.jpg gets converted to PNG.

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:119:
OptimizerConfig getConfigWithJpegConversionDisabled() {
getDefaultConfigWithJpegConversionDisabled

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:127:
HttpResponse rewrite(HttpResponse original) throws Exception {
move this before the 2 argument rewrite() method.

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:128:
return rewrite(original, new OptimizerConfig());
2 space indent

[satya3656, 2010-11-18 06:06:28]

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java
(right):

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java:62:
int pngLength = Integer.MAX_VALUE;
Ignoring this for now as it is not related to this change.

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java
(right):

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:42:
public void testSmallJPEGToPNGWithJpegConversionDisabled() throws Exception {
On 2010/11/17 17:39:53, gagan.goku wrote:
> could you also add a test case that shows that when jpegConversion is enabled,
> small.jpg gets converted to PNG.

Already there testSmallJPEGToPNG()

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:119:
OptimizerConfig getConfigWithJpegConversionDisabled() {
On 2010/11/17 17:39:53, gagan.goku wrote:
> getDefaultConfigWithJpegConversionDisabled

Done.

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:127:
HttpResponse rewrite(HttpResponse original) throws Exception {
On 2010/11/17 17:39:53, gagan.goku wrote:
> move this before the 2 argument rewrite() method.

Done.

http://codereview.appspot.com/3141041/diff/7001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:128:
return rewrite(original, new OptimizerConfig());
On 2010/11/17 17:39:53, gagan.goku wrote:
> 2 space indent

Done.

[gagan.goku, 2010-11-18 06:50:20]

LGTM

http://codereview.appspot.com/3141041/diff/16001/java/gadgets/src/test/java/o...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java
(right):

http://codereview.appspot.com/3141041/diff/16001/java/gadgets/src/test/java/o...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:42:
public void testSmallJPEGToPNGWithJpegConversionDisabled() throws Exception {
testSmallJPEGIsNotConvertedToPNGWithJpegConversionDisabled

[satya3656, 2010-11-18 13:11:22]

http://codereview.appspot.com/3141041/diff/16001/java/gadgets/src/test/java/o...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java
(right):

http://codereview.appspot.com/3141041/diff/16001/java/gadgets/src/test/java/o...
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizerTest.java:42:
public void testSmallJPEGToPNGWithJpegConversionDisabled() throws Exception {
On 2010/11/18 06:50:20, gagan.goku wrote:
> testSmallJPEGIsNotConvertedToPNGWithJpegConversionDisabled

Done.

[plindner1, 2010-11-18 16:58:36]

lgtm

[gagan.goku, 2010-11-19 02:55:03]

On 2010/11/18 16:58:36, plindner1 wrote:
> lgtm

Build looks good. Committed as r1036718.

[satya3656, 2010-11-19 05:59:14]

Thanks Paul for the quick review.

On 19 November 2010 08:25, <gagan.goku@gmail.com> wrote:

> On 2010/11/18 16:58:36, plindner1 wrote:
>
>> lgtm
>>
>
> Build looks good. Committed as r1036718.
>
>
> http://codereview.appspot.com/3141041/
>