Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3518)

Issue 313710043: Fix emoji text entry cusor position (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by fujiwara
Modified:
7 years, 3 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Fix emoji text entry cusor position Focus on emoji text entry by default Remove internal text buffer and use Gtk.Entry buffer instead. Implement cusor left, right, home, end on emoji annotation preedit. Committed: c580845167b54ccab76d8b72bdc797ef8d64d554

Patch Set 1 #

Patch Set 2 : Update with the latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -36 lines) Patch
M ui/gtk3/emojier.vala View 17 chunks +68 lines, -36 lines 0 comments Download

Messages

Total messages: 3
fujiwara
7 years, 3 months ago (2017-03-10 13:09:25 UTC) #1
Peng
lgtm
7 years, 3 months ago (2017-03-10 15:12:12 UTC) #2
fujiwara
7 years, 3 months ago (2017-03-13 02:58:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c580845167b54ccab76d8b72bdc797ef8d64d554 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b