Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(461)

Issue 3136042: code review 3136042: net: add ReadFrom and WriteTo windows version. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by vcc
Modified:
11 years ago
Reviewers:
CC:
rsc, brainman, golang-dev
Visibility:
Public.

Description

net: add ReadFrom and WriteTo windows version. Fixes issue 1275.

Patch Set 1 #

Patch Set 2 : code review 3136042: net: add ReadFrom and WriteTo windows version. #

Total comments: 2

Patch Set 3 : code review 3136042: net: add ReadFrom and WriteTo windows version. #

Total comments: 6

Patch Set 4 : code review 3136042: net: add ReadFrom and WriteTo windows version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -3 lines) Patch
M src/pkg/net/fd_windows.go View 1 2 3 2 chunks +70 lines, -3 lines 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 3 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8
vcc
Hello rsc, brainman (cc: golang-dev@googlegroups.com), I'd like you to review this change.
11 years ago (2010-11-16 13:00:48 UTC) #1
brainman
I tried your patch against http://code.google.com/p/go/issues/detail?id=1275, and it still doesn't work for me. Did you ...
11 years ago (2010-11-17 06:20:16 UTC) #2
vcc
Get remote peer address after receive UDP packet, please take another look. http://codereview.appspot.com/3136042/diff/2001/src/pkg/syscall/syscall_windows.go File src/pkg/syscall/syscall_windows.go ...
11 years ago (2010-11-17 07:40:38 UTC) #3
brainman
It is working for me now. Just couple of small renames. Thank you. http://codereview.appspot.com/3136042/diff/8001/src/pkg/syscall/syscall_windows.go File ...
11 years ago (2010-11-19 05:22:00 UTC) #4
vcc
Please take another look. http://codereview.appspot.com/3136042/diff/8001/src/pkg/syscall/syscall_windows.go File src/pkg/syscall/syscall_windows.go (right): http://codereview.appspot.com/3136042/diff/8001/src/pkg/syscall/syscall_windows.go#newcode471 src/pkg/syscall/syscall_windows.go:471: //sys _WSASendTo(s uint32, bufs *WSABuf, ...
11 years ago (2010-11-20 03:14:57 UTC) #5
brainman
LGTM. Leaving for Russ to OK it. Please, add "Fixes issue 1275" to CL description.
11 years ago (2010-11-21 23:26:32 UTC) #6
vcc
On 2010/11/21 23:26:32, brainman wrote: > LGTM. Leaving for Russ to OK it. > > ...
11 years ago (2010-11-22 04:49:06 UTC) #7
rsc
11 years ago (2010-11-22 16:01:33 UTC) #8
*** Submitted as f85e929d53c7 ***

net: add ReadFrom and WriteTo windows version.

Fixes issue 1275.

R=rsc, brainman
CC=golang-dev
http://codereview.appspot.com/3136042

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b