Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3306)

Issue 312660043: Update favorites category automatically by selecting emoji (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by fujiwara
Modified:
7 years, 1 month ago
Reviewers:
shawn.p.huang, penghuang
CC:
Peng Wu
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Update favorites category automatically by selecting emoji When you commit an emoji with Emojier, Favorite category will be shown on GUI. Now a custom annotation also can be assigned to a favorite emoji by gsetting command. R=penghuang@google.com Committed: 1159093dea3fdb8ceb62157f06b3560f8fc28378

Patch Set 1 #

Patch Set 2 : Updated with the latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -10 lines) Patch
M data/ibus.schemas.in View 1 chunk +13 lines, -0 lines 0 comments Download
M src/ibusemoji.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gtk3/emojier.vala View 5 chunks +61 lines, -2 lines 0 comments Download
M ui/gtk3/emojierapp.vala View 2 chunks +18 lines, -0 lines 0 comments Download
M ui/gtk3/ibusemojidialog.h View 1 chunk +14 lines, -6 lines 0 comments Download
M ui/gtk3/panel.vala View 4 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 3
fujiwara
7 years, 1 month ago (2017-05-08 08:56:40 UTC) #1
penghuang
On 2017/05/08 08:56:40, fujiwara wrote: lgtm
7 years, 1 month ago (2017-05-08 13:34:09 UTC) #2
fujiwara
7 years, 1 month ago (2017-05-09 04:58:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1159093dea3fdb8ceb62157f06b3560f8fc28378 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b