Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 312520043: Fix memory leak in IBus.Bus.get_global_engine() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by fujiwara
Modified:
7 years, 3 months ago
Reviewers:
shawn.p.huang, Peng
CC:
eric_ers35.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix memory leak in IBus.Bus.get_global_engine() Fix the memory leak by setting the transfer mode annotation to full. BUG=https://github.com/ibus/ibus/pull/1899 R=Shawn.P.Huang@gmail.com Committed: 0a244817338c943ffe03cd5b6ecf094ffd156f80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ibusbus.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
fujiwara
7 years, 3 months ago (2017-02-28 06:29:26 UTC) #1
Peng
On 2017/02/28 06:29:26, fujiwara wrote: lgtm
7 years, 3 months ago (2017-02-28 09:46:00 UTC) #2
fujiwara
7 years, 3 months ago (2017-03-01 04:26:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a244817338c943ffe03cd5b6ecf094ffd156f80 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b