cqa-scheduler

cqa-scheduler

[Nicola Baldo, 2013-11-28 09:13:57]

I had already reviewed this code previously to the submission to codereview.
Now, I just have a couple of minor comments related with the doxygen
documentation; other than this, I think the code is ready for merge.

https://codereview.appspot.com/31010043/diff/1/src/lte/model/cqa-ff-mac-sched...
File src/lte/model/cqa-ff-mac-scheduler.h (right):

https://codereview.appspot.com/31010043/diff/1/src/lte/model/cqa-ff-mac-sched...
src/lte/model/cqa-ff-mac-scheduler.h:54: struct CqasFlowPerf_t
please add doxygen here

https://codereview.appspot.com/31010043/diff/1/src/lte/model/cqa-ff-mac-sched...
src/lte/model/cqa-ff-mac-scheduler.h:69: * This class implements the interface
defined by the FfMacScheduler abstract class
I suggest to change this to reflect the actual name of the scheduler, and
referring to the documentation/paper for the description.

[Marco Miozzo, 2013-11-28 09:38:33]

very interesting work, I'll review it more in depth asap.
Let me just note that, I've recently solve a bug in UL grant HARQ process, you
may find more info at the following link:
https://www.nsnam.org/bugzilla/show_bug.cgi?id=1803

[Biljana Bojović, 2013-12-03 15:51:07]

Thank you very much for comments.

I have checked the change set 10449
(http://code.nsnam.org/ns-3-dev/diff/234f4746e6a7/src/lte/model/pf-ff-mac-sche...)
that Marco mentioned in his review, and I think there is no problem in adding it
to this scheduler. I can add it into the version for merging.

https://codereview.appspot.com/31010043/diff/1/src/lte/model/cqa-ff-mac-sched...
File src/lte/model/cqa-ff-mac-scheduler.h (right):

https://codereview.appspot.com/31010043/diff/1/src/lte/model/cqa-ff-mac-sched...
src/lte/model/cqa-ff-mac-scheduler.h:53: 
/**
* CqasFlowPerf_t structure is used to keep track of different variables that are
used in scheduling algorithm.
*/

https://codereview.appspot.com/31010043/diff/1/src/lte/model/cqa-ff-mac-sched...
src/lte/model/cqa-ff-mac-scheduler.h:54: struct CqasFlowPerf_t
On 2013/11/28 09:13:57, Nicola Baldo wrote:
> please add doxygen here

Done.

https://codereview.appspot.com/31010043/diff/1/src/lte/model/cqa-ff-mac-sched...
src/lte/model/cqa-ff-mac-scheduler.h:69: * This class implements the interface
defined by the FfMacScheduler abstract class
On 2013/11/28 09:13:57, Nicola Baldo wrote:
> I suggest to change this to reflect the actual name of the scheduler, and
> referring to the documentation/paper for the description.

I am not sure on what are you referring to. "This class implements the interface
defined by the FfMacScheduler abstract class " is correct sentence...

https://codereview.appspot.com/31010043/diff/1/src/lte/model/cqa-ff-mac-sched...
src/lte/model/cqa-ff-mac-scheduler.h:69: * This class implements the interface
defined by the FfMacScheduler abstract class
CqaFFMacSCheduler is implementation of algorithm proposed by B. Bojovic and N.
Baldo in "A new Channel and QoS Aware Scheduler to enhance the capacity of Voice
over LTE systems - See more at:
http://www.cttc.es/publication/a-new-channel-and-qos-aware-scheduler-to-enhan...
"