Issue 310041: code review 310041: 5g/6g/8g: fix double function call in slice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 310041: code review 310041: 5g/6g/8g: fix double function call in slice (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

5g/6g/8g: fix double function call in slice Fixes issue 654.

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -97 lines)			Patch
M	src/cmd/5g/ggen.c	View	5 chunks	+24 lines, -32 lines	0 comments	Download
M	src/cmd/6g/ggen.c	View	5 chunks	+24 lines, -32 lines	0 comments	Download
M	src/cmd/8g/gg.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/8g/ggen.c	View	5 chunks	+24 lines, -33 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	2 chunks	+6 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug261.go	View	1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-08 22:19:27 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=ac91dbef6192 *** 5g/6g/8g: fix double function call in slice Fixes issue 654. ...

15 years ago (2010-03-08 22:19:36 UTC) #2

LGTM