Issue 309640043: src: Enable to type digit to commit emoji on lookup window

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 309640043: src: Enable to type digit to commit emoji on lookup window (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by fujiwara

Modified:
7 years, 8 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

src: Enable to type digit to commit emoji on lookup window Enables to commit an emoji on the lookup window by a digit key. Before this patch, Ctrl-Shift-U, "11" shows emojis of 11 clock. After this patch, Ctrl-Shift-U, "11" commits an emoji of 1 clock. Probably Ctrl-Shift-U, "clock" can be a workaround. BUG=rhbz#1380690 R=Shawn.P.Huang@gmail.com Committed: 4d86e59d0245df6d3a6aa1a32cdf7702b6dc7f0d

Patch Set 1 #

Patch Set 2 : Updated with the laster master #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -2 lines)			Patch
	M	src/ibusenginesimple.c	View	1	3 chunks	+78 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 8 months ago (2016-10-06 06:35:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4d86e59d0245df6d3a6aa1a32cdf7702b6dc7f0d (presubmit successful).

Expand All Messages | Collapse All Messages