Issue 308880043: Hardcode shadows-multidex ShadowProvider file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 308880043: Hardcode shadows-multidex ShadowProvider file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 5 months ago by mikecase

Modified:
8 years, 4 months ago

Reviewers:
jbudorick

Base URL:
https://chromium.googlesource.com/external/robolectric.git@3.0-chromium

Visibility:
Public.

More Reviews

Description

Hardcode shadows-multidex ShadowProvider file. These files are generated by the Robolectric annotation processor at compile time. The generated files are difficult to use given our Chromium build system (GN). Hardcoding the file for convenience. BUG= R=jbudorick@chromium.org Committed: e38b49a12fdfa17a94f0382cc8ffaf69132fd09b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed spelling of conveniecne #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	A	robolectric-shadows/shadows-multidex/src/main/resources/META-INF/services/org.robolectric.internal.ShadowProvider	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jbudorick

I'm going to have to talk to you in person to get a bit more ...

8 years, 4 months ago (2016-08-01 19:33:13 UTC) #2

mikecase

8 years, 4 months ago (2016-08-01 21:06:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e38b49a12fdfa17a94f0382cc8ffaf69132fd09b (presubmit successful).

Expand All Messages | Collapse All Messages