Issue 3087042: Handle empty response for proxy content

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by zhoresh

Modified:
15 years, 3 months ago

Reviewers:
johnfargo, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Base64InpoutStream doesn't handle empty stream correctly. So avoid translation of empty response.

Patch Set 1 #

Total comments: 1

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java	View		1 chunk	+8 lines, -4 lines	1 comment	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnfargo

LGTM http://codereview.appspot.com/3087042/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java (right): http://codereview.appspot.com/3087042/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode440 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:440: if (httpResponse.getContentLength() > 0) { FMI, in which ...

15 years, 3 months ago (2010-11-17 01:42:25 UTC) #2

zhoresh

Submitted to r1035911 Stack trace: java.io.IOException: Underlying input stream returned zero bytes at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:286) at ...

15 years, 3 months ago (2010-11-17 03:12:02 UTC) #3

johnfargo

15 years, 3 months ago (2010-11-17 06:58:45 UTC) #4

Strange, I'm surprised IOUtils doesn't catch that. Workaround is fine.

On Tue, Nov 16, 2010 at 7:11 PM, Ziv Horesh <zhoresh@gmail.com> wrote:

> Submitted to r1035911
>
> Stack trace:
>
> java.io.IOException: Underlying input stream returned zero bytes
>     at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:286)
>     at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:324)
>     at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:176)
>     at java.io.InputStreamReader.read(InputStreamReader.java:184)
>     at java.io.Reader.read(Reader.java:140)
>     at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1128)
>     at org.apache.commons.io.IOUtils.copy(IOUtils.java:1104)
>     at org.apache.commons.io.IOUtils.copy(IOUtils.java:1050)
>     at org.apache.commons.io.IOUtils.toString(IOUtils.java:359)
>     at
>
org.apache.shindig.gadgets.servlet.GadgetsHandlerService.createProxyResponse(GadgetsHandlerService.java:445)
>     at
>
org.apache.shindig.gadgets.servlet.GadgetsHandlerService.getProxy(GadgetsHandlerService.java:242)
>     at
>
org.apache.shindig.gadgets.servlet.GadgetsHandlerServiceTest.testGetProxyEmptyData(GadgetsHandlerServiceTest.java:472)
>
> Yes the stream return zero bytes - it is empty, but that doesn't mean it is
> bad....
>
>
>
>
> On Tue, Nov 16, 2010 at 5:42 PM, <johnfargo@gmail.com> wrote:
>
>> LGTM
>>
>>
>>
>>
http://codereview.appspot.com/3087042/diff/1/java/gadgets/src/main/java/org/a...
>> File
>>
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
>> (right):
>>
>>
>>
http://codereview.appspot.com/3087042/diff/1/java/gadgets/src/main/java/org/a...
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:440:
>> if (httpResponse.getContentLength() > 0) {
>> FMI, in which way does the stream barf w/ 0 length?
>>
>>
>> http://codereview.appspot.com/3087042/
>>
>
>

Expand All Messages | Collapse All Messages