Issue 308560043: Don't merge non-overlapping ledger lines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 308560043: Don't merge non-overlapping ledger lines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by pwm

Modified:
8 years, 6 months ago

Reviewers:
thomasmorley651

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Don't merge non-overlapping ledger lines Issue 4979/2: Add regression test for non-merging ledger lines Issue 4979/1: Don't merge non-overlapping ledger lines

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -26 lines)			Patch
	A	input/regression/ledger-lines-non-merging.ly	View		1 chunk	+32 lines, -0 lines	0 comments	Download
	M	lily/ledger-line-spanner.cc	View		4 chunks	+39 lines, -26 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thomasmorley651

8 years, 6 months ago (2016-10-03 10:10:35 UTC) #2

On 2016/10/02 20:46:47, pwm wrote:
> Please review, fixes issue 4979.
> -Paul

I can't review C++, but I applied your patch and tested it with my code from
http://lists.gnu.org/archive/html/lilypond-user/2012-07/msg00336.html
(A far more extreme example than your regtest)

Works nicely.

So far: LGTM

Expand All Messages | Collapse All Messages