Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(925)

Issue 308560043: Don't merge non-overlapping ledger lines (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by pwm
Modified:
3 years, 3 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Don't merge non-overlapping ledger lines Issue 4979/2: Add regression test for non-merging ledger lines Issue 4979/1: Don't merge non-overlapping ledger lines

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -26 lines) Patch
A input/regression/ledger-lines-non-merging.ly View 1 chunk +32 lines, -0 lines 0 comments Download
M lily/ledger-line-spanner.cc View 4 chunks +39 lines, -26 lines 0 comments Download

Messages

Total messages: 2
pwm
Please review, fixes issue 4979. -Paul
3 years, 3 months ago (2016-10-02 20:46:47 UTC) #1
thomasmorley651
3 years, 3 months ago (2016-10-03 10:10:35 UTC) #2
On 2016/10/02 20:46:47, pwm wrote:
> Please review, fixes issue 4979.
> -Paul

I can't review C++, but I applied your patch and tested it with my code from
http://lists.gnu.org/archive/html/lilypond-user/2012-07/msg00336.html
(A far more extreme example than your regtest)

Works nicely.

So far: LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b