Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2354)

Issue 308430043: Add output-attributes grob property to replace id (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by pwm
Modified:
3 years ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add output-attributes grob property to replace id Allows setting multiple attributes on group nodes (<g> in SVG output), specified as an alist.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improve convert rule, keep id property #

Patch Set 3 : An even better convert rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -27 lines) Patch
M Documentation/changes.tely View 1 1 chunk +8 lines, -0 lines 0 comments Download
D input/regression/id.ly View 1 1 chunk +1 line, -1 line 0 comments Download
A input/regression/output-attributes.ly View 1 chunk +15 lines, -0 lines 0 comments Download
M lily/grob.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M lily/stencil-integral.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/stencil-interpret.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M python/convertrules.py View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 chunks +9 lines, -7 lines 0 comments Download
M scm/define-stencil-commands.scm View 3 chunks +3 lines, -3 lines 0 comments Download
M scm/output-ps.scm View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/output-svg.scm View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6
pwm
Please review, thanks, -Paul
3 years, 1 month ago (2016-09-18 20:54:44 UTC) #1
dak
https://codereview.appspot.com/308430043/diff/1/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/308430043/diff/1/python/convertrules.py#newcode3906 python/convertrules.py:3906: @rule ((2, 19, 49), r"""\override ... .id = "a-string" ...
3 years ago (2016-09-27 10:06:26 UTC) #2
pwm
On 2016/09/27 10:06:26, dak wrote: > https://codereview.appspot.com/308430043/diff/1/python/convertrules.py > File python/convertrules.py (right): > > https://codereview.appspot.com/308430043/diff/1/python/convertrules.py#newcode3906 > ...
3 years ago (2016-09-27 18:46:29 UTC) #3
pwm
Improve convert rule, keep id property
3 years ago (2016-09-28 03:01:44 UTC) #4
pwm
Patch Set 2: Improve convert rule, keep id property.
3 years ago (2016-09-28 03:14:55 UTC) #5
pwm
3 years ago (2016-09-28 14:45:51 UTC) #6
An even better convert rule
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b