Fix warning messages during panel resizes

Fix warning messages during panel resizes

Move gtk_window_resize().
Seems calling gtk_window_resize() is not good during
gtk_widget_get_preferred_width/height() is called.

Committed: af66ace771fc16a23e7a5841d2f0bd79789e009d

[Peng, 2016-09-09 10:54:42]

https://codereview.appspot.com/308320043/diff/1/ui/gtk3/candidatepanel.vala
File ui/gtk3/candidatepanel.vala (right):

https://codereview.appspot.com/308320043/diff/1/ui/gtk3/candidatepanel.vala#n...
ui/gtk3/candidatepanel.vala:243: * in gtk_widget_size_allocate_with_baseline()
*/
Could you give me a link where is this warning in gtk code?

[Peng, 2016-09-09 11:07:16]

https://codereview.appspot.com/308320043/diff/1/ui/gtk3/candidatepanel.vala
File ui/gtk3/candidatepanel.vala (right):

https://codereview.appspot.com/308320043/diff/1/ui/gtk3/candidatepanel.vala#n...
ui/gtk3/candidatepanel.vala:135: m_toplevel.resize(1, 1);
Can we call this in update()?

[fujiwara, 2016-09-12 10:28:24]

https://codereview.appspot.com/308320043/diff/1/ui/gtk3/candidatepanel.vala
File ui/gtk3/candidatepanel.vala (right):

https://codereview.appspot.com/308320043/diff/1/ui/gtk3/candidatepanel.vala#n...
ui/gtk3/candidatepanel.vala:243: * in gtk_widget_size_allocate_with_baseline()
*/
On 2016/09/09 10:54:41, Peng wrote:
> Could you give me a link where is this warning in gtk code?

https://git.gnome.org/browse/gtk+/tree/gtk/gtkwidget.c#n5973

[fujiwara, 2016-09-13 10:27:34]

https://codereview.appspot.com/308320043/diff/1/ui/gtk3/candidatepanel.vala
File ui/gtk3/candidatepanel.vala (right):

https://codereview.appspot.com/308320043/diff/1/ui/gtk3/candidatepanel.vala#n...
ui/gtk3/candidatepanel.vala:135: m_toplevel.resize(1, 1);
On 2016/09/09 11:07:16, Peng wrote:
> Can we call this in update()?

Done.

[Peng, 2016-09-13 13:16:45]

lgtm

https://codereview.appspot.com/308320043/diff/20001/ui/gtk3/candidatepanel.vala
File ui/gtk3/candidatepanel.vala (right):

https://codereview.appspot.com/308320043/diff/20001/ui/gtk3/candidatepanel.va...
ui/gtk3/candidatepanel.vala:231: public override void get_preferred_width(out
int minimum_width, out int natural_width) {
Remove those two overrides?

https://codereview.appspot.com/308320043/diff/20001/ui/gtk3/propertypanel.vala
File ui/gtk3/propertypanel.vala (right):

https://codereview.appspot.com/308320043/diff/20001/ui/gtk3/propertypanel.val...
ui/gtk3/propertypanel.vala:247: public override void get_preferred_width(out int
minimum_width,
After removing m_toplevel.resize(), those two overrides are not necessary
anymore.

[fujiwara, 2016-09-14 04:34:30]

https://codereview.appspot.com/308320043/diff/20001/ui/gtk3/candidatepanel.vala
File ui/gtk3/candidatepanel.vala (right):

https://codereview.appspot.com/308320043/diff/20001/ui/gtk3/candidatepanel.va...
ui/gtk3/candidatepanel.vala:231: public override void get_preferred_width(out
int minimum_width, out int natural_width) {
On 2016/09/13 13:16:45, Peng wrote:
> Remove those two overrides?

Done.

https://codereview.appspot.com/308320043/diff/20001/ui/gtk3/propertypanel.vala
File ui/gtk3/propertypanel.vala (right):

https://codereview.appspot.com/308320043/diff/20001/ui/gtk3/propertypanel.val...
ui/gtk3/propertypanel.vala:247: public override void get_preferred_width(out int
minimum_width,
On 2016/09/13 13:16:45, Peng wrote:
> After removing m_toplevel.resize(), those two overrides are not necessary
> anymore.

Done.

[fujiwara, 2016-09-14 04:34:51]

Committed patchset #3 (id:40001) manually as
af66ace771fc16a23e7a5841d2f0bd79789e009d (presubmit successful).