Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2025)

Issue 307400043: src: Hide lookup table if emoji annotation does not hit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by fujiwara
Modified:
7 years, 8 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

src: Hide lookup table if emoji annotation does not hit If emoji annotation hits "aaa" but not "aaab", hide the lookup window with "aaab". Also hide the lookup window with Escape key. BUG=rhbz#1380675 Committed: e795eda1a3b054e6fdc921bfe04c83733761905f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/ibusenginesimple.c View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 3
fujiwara
7 years, 8 months ago (2016-10-05 06:59:39 UTC) #1
Peng
lgtm
7 years, 8 months ago (2016-10-05 11:04:15 UTC) #2
fujiwara
7 years, 8 months ago (2016-10-06 06:28:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e795eda1a3b054e6fdc921bfe04c83733761905f (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b