Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 3071041: code review 3071041: flag: handle multiple calls to flag.Parse (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by rsc
Modified:
14 years, 3 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

flag: handle multiple calls to flag.Parse

Patch Set 1 #

Patch Set 2 : code review 3071041: flag: handle multiple calls to flag.Parse #

Patch Set 3 : code review 3071041: flag: handle multiple calls to flag.Parse #

Patch Set 4 : code review 3071041: flag: handle multiple calls to flag.Parse #

Patch Set 5 : code review 3071041: flag: handle multiple calls to flag.Parse #

Patch Set 6 : code review 3071041: flag: handle multiple calls to flag.Parse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -67 lines) Patch
A src/pkg/flag/export_test.go View 1 chunk +32 lines, -0 lines 0 comments Download
M src/pkg/flag/flag.go View 1 2 3 4 9 chunks +45 lines, -67 lines 0 comments Download
M src/pkg/flag/flag_test.go View 4 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change.
14 years, 3 months ago (2010-12-06 19:22:32 UTC) #1
rsc1
R=r This change keeps flag.Parse from crashing if called multiple times. It also lets one ...
14 years, 3 months ago (2010-12-06 19:27:47 UTC) #2
r
looks good but wants a test if feasible and maybe a sentence of new package ...
14 years, 3 months ago (2010-12-06 19:33:09 UTC) #3
rsc
Hello r (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 3 months ago (2010-12-07 16:50:09 UTC) #4
r
LGTM
14 years, 3 months ago (2010-12-07 16:57:19 UTC) #5
rsc
14 years, 3 months ago (2010-12-07 18:19:03 UTC) #6
*** Submitted as cc69ceb37529 ***

flag: handle multiple calls to flag.Parse

R=r
CC=golang-dev
http://codereview.appspot.com/3071041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b