Issue 307050043: Fix GVariant leaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 307050043: Fix GVariant leaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by fujiwara

Modified:
7 years, 8 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix GVariant leaks The expectation is that g_dbus_message_set_body() takes ownership of the GVariant, but this does not happen if the BusInputContext connection is NULL. Call g_variant_unref() in that case to free the memory. Alternatively, a GVariantBuilder could be used. BUG=https://github.com/ibus/ibus/pull/1872 R=Shawn.P.Huang@gmail.com Committed: 997e5cb1b100c6af267b8121445db1db7e580d5f

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	bus/inputcontext.c	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 8 months ago (2016-08-18 02:17:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
997e5cb1b100c6af267b8121445db1db7e580d5f (presubmit successful).

Expand All Messages | Collapse All Messages