Issue 306850043: ticket:12140: Pass StringPiece by value, externally.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 306850043: ticket:12140: Pass StringPiece by value, externally. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 4 months ago by roubert (google)

Modified:
8 years, 4 months ago

Reviewers:
markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu/trunk

Visibility:
Public.

ticket:12140: Pass StringPiece by value, externally. R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/39064

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -28 lines)			Patch
M	source/common/bytestriebuilder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/common/unicode/bytestriebuilder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/common/unicode/idna.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	source/common/unicode/unistr.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/common/unistr.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/common/uts46.cpp	View	6 chunks	+12 lines, -12 lines	0 comments	Download
M	source/i18n/decimfmt.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/i18n/fmtable.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	source/i18n/numfmt.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/i18n/unicode/decimfmt.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/i18n/unicode/fmtable.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	source/i18n/unicode/numfmt.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4

roubert (google)

Updated after the design decision made in the ICU meeting. PTAL

8 years, 4 months ago (2016-08-17 18:23:15 UTC) #2

roubert (google)

8 years, 4 months ago (2016-08-17 19:07:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 39064 (presubmit successful).