Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6173)

Issue 305950043: Fix make dist (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by fujiwara
Modified:
7 years, 9 months ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix make dist 'make dist' has different directories between builddir and srcdir. src/tests/runtest gets the builddir of ibus-memconf from the srcdir of memconf.xml and the builddir of ibus-engine-simple from the srcdir of simple.xml. bindings/pygobject/test-override-ibus.py runs IBus.Keymap.new() and gets the path of keymaps from IBUS_KEYMAP_PATH variable. bindings/vala/ibus-1.0.vapi needs to be cleaned by 'make distclean'. R=shawn.p.huang@gmail.com Committed: eee7a132d686cb8d9c36c632523649745487b503

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M Makefile.am View 1 chunk +0 lines, -1 line 0 comments Download
M bindings/pygobject/Makefile.am View 2 chunks +3 lines, -1 line 0 comments Download
M bindings/vala/Makefile.am View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ibuskeymap.c View 1 chunk +5 lines, -1 line 0 comments Download
M src/tests/runtest View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
fujiwara
7 years, 9 months ago (2016-07-26 11:05:57 UTC) #1
shawn.p.huang_gmail.com
lgtm <takao.fujiwara1@gmail.com>于2016年7月26日周二 上午7:05写道: > Reviewers: shawn.p.huang_gmail.com, > > Description: > Fix make dist > > ...
7 years, 9 months ago (2016-07-26 12:47:40 UTC) #2
fujiwara
7 years, 9 months ago (2016-07-27 02:26:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eee7a132d686cb8d9c36c632523649745487b503 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b