Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(418)

Issue 3055: combined patches from http://bugs.python.org/issue3187 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by GvR
Modified:
12 years, 4 months ago
Reviewers:
haypo
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Description

http://bugs.python.org/issue3187 Committed revision 66743.

Patch Set 1 #

Patch Set 2 : Victor's latest patch (Sept 29 '08) #

Patch Set 3 : More complete patch from Victor #

Patch Set 4 : Number 3 from Victor #

Patch Set 5 : My final version of Victor's patches #

Patch Set 6 : One more tweak (fold some long lines) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -144 lines) Patch
M Lib/fnmatch.py View 1 2 3 4 2 chunks +17 lines, -10 lines 0 comments Download
M Lib/genericpath.py View 2 chunks +3 lines, -2 lines 0 comments Download
M Lib/glob.py View 1 2 3 4 3 chunks +11 lines, -6 lines 0 comments Download
M Lib/io.py View 1 2 3 4 2 chunks +7 lines, -8 lines 0 comments Download
M Lib/posixpath.py View 1 2 3 4 17 chunks +128 lines, -43 lines 0 comments Download
M Lib/test/test_fnmatch.py View 1 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M Lib/test/test_posix.py View 3 4 1 chunk +1 line, -1 line 0 comments Download
M Lib/test/test_posixpath.py View 3 4 5 10 chunks +136 lines, -14 lines 0 comments Download
M Lib/test/test_unicode_file.py View 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Misc/NEWS View 2 chunks +8 lines, -2 lines 0 comments Download
M Modules/posixmodule.c View 2 3 4 5 chunks +35 lines, -55 lines 0 comments Download

Messages

Total messages: 8
GvR
Hi Victor, I've combined your patches and added some comments. http://codereview.appspot.com/3055/diff/1/4 File Lib/fnmatch.py (left): http://codereview.appspot.com/3055/diff/1/4#oldcode50 ...
13 years, 3 months ago (2008-08-22 19:04:51 UTC) #1
GvR
Victor's latest patch (Sept 29 '08)
13 years, 2 months ago (2008-09-30 17:11:06 UTC) #2
GvR
Could you add docs and unittests for all the new functionality? http://codereview.appspot.com/3055/diff/401/603 File Lib/fnmatch.py (right): ...
13 years, 2 months ago (2008-09-30 18:10:41 UTC) #3
GvR
More complete patch from Victor
13 years, 2 months ago (2008-09-30 22:09:55 UTC) #4
GvR
Re: docs: I meant docs in the Doc directory. It looks like I was too ...
13 years, 2 months ago (2008-10-01 00:00:31 UTC) #5
GvR
Hi Victor, I hope you're getting these emails. I'll be checking this in, with some ...
13 years, 2 months ago (2008-10-02 16:44:50 UTC) #6
GvR
Number 3 from Victor
13 years, 2 months ago (2008-10-02 17:57:24 UTC) #7
GvR
13 years, 2 months ago (2008-10-02 18:55:58 UTC) #8
Submitted as r66743.

Thanks Victor!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b