src/cmd/gofmt/rewrite.go - Issue 3050041: code review 3050041: go/ast: use token.Pos instead of token.Position; adjus...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gofmt/rewrite.go

Issue 3050041: code review 3050041: go/ast: use token.Pos instead of token.Position; adjus... (Closed)

Patch Set: code review 3050041: go/ast: use token.Pos instead of token.Position; adjus... Created 14 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gofmt/rewrite.go

===================================================================

--- a/src/cmd/gofmt/rewrite.go

+++ b/src/cmd/gofmt/rewrite.go

@@ -37,7 +37,7 @@

// but there are problems with preserving formatting and also

// with what a wildcard for a statement looks like.

func parseExpr(s string, what string) ast.Expr {

- x, err := parser.ParseExpr("input", s)

+ x, err := parser.ParseExpr(fset, "input", s)

if err != nil {

fmt.Fprintf(os.Stderr, "parsing %s %s: %s\n", what, s, err)

os.Exit(2)

@@ -66,7 +66,7 @@

}

-var positionType = reflect.Typeof(token.Position{})

+var positionType = reflect.Typeof(token.NoPos)

var identType = reflect.Typeof((*ast.Ident)(nil))

« no previous file with comments | « src/cmd/gofmt/gofmt.go ('k') | src/cmd/goinstall/main.go » ('j') | no next file with comments »