Issue 30490043: Backport to es53 branch: r5626, r5627, r5630

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30490043: Backport to es53 branch: r5626, r5627, r5630 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by kpreid2

Modified:
12 years, 3 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/branches/es53/

Visibility:
Public.

More Reviews

Description

Backport security patch r5630 Reject, in the mitigator, JS reserved names written with escapes together with preceding related changes r5626 Update third_party/js/{acorn,escodegen}. r5627 Remove redundant parent node tracking from mitigateSrcGotchas. The merge command was svn merge -c 5626,5627,5630 https://google-caja.googlecode.com/svn/trunk and there were no conflicts. @r5632

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1131 lines, -703 lines)			Patch
M	.	View	0 chunks	+0 lines, -0 lines	0 comments	Download
MM	build.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/ses/createExports.js	View	1 chunk	+17 lines, -4 lines	0 comments	Download
M	src/com/google/caja/ses/exportsToSES.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/ses/mitigateGotchas.js	View	12 chunks	+86 lines, -22 lines	0 comments	Download
M	tests/com/google/caja/ses/ses-tests.json	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	tests/com/google/caja/ses/test-ses-mitigation.html	View	1 chunk	+13 lines, -14 lines	0 comments	Download
M	tests/com/google/caja/ses/test-ses-mitigation.js	View	1 chunk	+90 lines, -37 lines	0 comments	Download
M	third_party	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	third_party/js/acorn/acorn.js	View	37 chunks	+179 lines, -122 lines	0 comments	Download
M	third_party/js/escodegen/escodegen.js	View	33 chunks	+235 lines, -373 lines	0 comments	Download
M	third_party/js/escodegen/estraverse.js	View	8 chunks	+499 lines, -130 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages