Issue 3046041: Allow null values to cancel values in parent containers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3046041: Allow null values to cancel values in parent containers

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by jtarrio

Modified:
15 years, 1 month ago

Reviewers:
johnfargo

CC:
shindig.remailer_gmail.com

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Restoring a small piece of functionality that was lost with my refactoring: in a child container, you can use a null value to avoid inheriting a key from the parent.

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+49 lines, -31 lines)			Patch
java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java	View	2 chunks	+9 lines, -3 lines	0 comments	Download
java/common/src/main/java/org/apache/shindig/config/ExpressionContainerConfig.java	View	3 chunks	+10 lines, -10 lines	0 comments	Download
java/common/src/main/java/org/apache/shindig/config/JsonContainerConfigLoader.java	View	3 chunks	+7 lines, -11 lines	0 comments	Download
java/common/src/test/java/org/apache/shindig/config/BasicContainerConfigTest.java	View	3 chunks	+12 lines, -7 lines	0 comments	Download
java/common/src/test/java/org/apache/shindig/config/JsonContainerConfigLoaderTest.java	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

johnfargo

15 years, 1 month ago (2010-11-12 01:20:38 UTC) #2

LGTM -- committing.

On 2010/11/11 21:53:25, jtarrio wrote:

Expand All Messages | Collapse All Messages