Issue 304120043: Do not resolve host name to IP when recording (Closed)
|
Created:
10 years, 3 months ago by nednguyen Modified:
10 years, 3 months ago Reviewers:
petrcermak Base URL:
https://github.com/chromium/web-page-replay@master Visibility:
Public. |
DescriptionDo not resolve host name to IP when recording
BUG=#73
R=petrcermak@chromium.org
Committed: 75460ca0577b0cc1013e5d11ef0057a707fc81df
Patch Set 1 #Patch Set 2 : update #Patch Set 3 : update #
Total comments: 8
Patch Set 4 : Address Petr's comment #MessagesTotal messages: 7
On 2016/07/14 18:26:43, nednguyen wrote: The test still need to be updated but can you verify that this fix the SSL Handshake error on your machine?
Sign in to reply to this message.
Unfortunately, I still get the same error when I run this locally :-( (DEBUG) 2016-07-15 10:20:28,637 httpclient.__call__:324 RealHttpFetch: i1.sndcdn.com /artworks-000139618215-ubm1i6-t500x500.jpg (WARNING) 2016-07-15 10:20:28,661 httpclient.__call__:360 Retrying fetch GET https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), ('upgrade-insecure-requests', '1')]: SSLError(1, '_ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure') (WARNING) 2016-07-15 10:20:28,682 httpclient.__call__:360 Retrying fetch GET https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), ('upgrade-insecure-requests', '1')]: SSLError(1, '_ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure') (WARNING) 2016-07-15 10:20:28,705 httpclient.__call__:360 Retrying fetch GET https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), ('upgrade-insecure-requests', '1')]: SSLError(1, '_ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure') (CRITICAL) 2016-07-15 10:20:28,727 httpclient.__call__:362 Could not fetch GET https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), ('upgrade-insecure-requests', '1')]: SSLError(1, '_ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure') (WARNING) 2016-07-15 10:20:28,727 httpproxy.do_parse_and_handle_one_request:258 Failed to find response for: GET https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), ('upgrade-insecure-requests', '1')] (91ms) Thanks, Petr https://codereview.appspot.com/304120043/diff/40001/httpclient.py File httpclient.py (right): https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode304 httpclient.py:304: 'Unable to find host ip for name: %s', connection_host) nit: s/host ip for name/IP for host name/ https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode306 httpclient.py:306: connection_host = connection_ip You can just set connection_host on line 301. No point in defining connection_ip at all. https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode374 httpclient.py:374: real_dns_lookup: a function that resolves a host to an IP. Remove this line https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode490 httpclient.py:490: http_archive, inject_script) nit: These two arguments should now fit on the previous line.
Sign in to reply to this message.
On 2016/07/15 09:22:22, petrcermak wrote: > Unfortunately, I still get the same error when I run this locally :-( > > (DEBUG) 2016-07-15 10:20:28,637 httpclient.__call__:324 RealHttpFetch: > http://i1.sndcdn.com /artworks-000139618215-ubm1i6-t500x500.jpg > (WARNING) 2016-07-15 10:20:28,661 httpclient.__call__:360 Retrying fetch GET > https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg > [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), > ('upgrade-insecure-requests', '1')]: SSLError(1, '_ssl.c:510: error:14077410:SSL > routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure') > (WARNING) 2016-07-15 10:20:28,682 httpclient.__call__:360 Retrying fetch GET > https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg > [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), > ('upgrade-insecure-requests', '1')]: SSLError(1, '_ssl.c:510: error:14077410:SSL > routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure') > (WARNING) 2016-07-15 10:20:28,705 httpclient.__call__:360 Retrying fetch GET > https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg > [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), > ('upgrade-insecure-requests', '1')]: SSLError(1, '_ssl.c:510: error:14077410:SSL > routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure') > (CRITICAL) 2016-07-15 10:20:28,727 httpclient.__call__:362 Could not fetch GET > https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg > [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), > ('upgrade-insecure-requests', '1')]: SSLError(1, '_ssl.c:510: error:14077410:SSL > routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure') > (WARNING) 2016-07-15 10:20:28,727 httpproxy.do_parse_and_handle_one_request:258 > Failed to find response for: GET > https://i1.sndcdn.com/artworks-000139618215-ubm1i6-t500x500.jpg > [('accept-encoding', 'gzip,deflate,br'), ('host', 'i1.sndcdn.com'), > ('upgrade-insecure-requests', '1')] (91ms) Oh, these are different from the ones in https://bugs.chromium.org/p/chromium/issues/detail?id=499491 At least we can now record http://www.theverge.com/2015/6/5/8727399/parrot-bebop-drone-review with this fix > > Thanks, > Petr > > https://codereview.appspot.com/304120043/diff/40001/httpclient.py > File httpclient.py (right): > > https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode304 > httpclient.py:304: 'Unable to find host ip for name: %s', connection_host) > nit: s/host ip for name/IP for host name/ > > https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode306 > httpclient.py:306: connection_host = connection_ip > You can just set connection_host on line 301. No point in defining connection_ip > at all. > > https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode374 > httpclient.py:374: real_dns_lookup: a function that resolves a host to an IP. > Remove this line > > https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode490 > httpclient.py:490: http_archive, inject_script) > nit: These two arguments should now fit on the previous line.
Sign in to reply to this message.
https://codereview.appspot.com/304120043/diff/40001/httpclient.py File httpclient.py (right): https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode304 httpclient.py:304: 'Unable to find host ip for name: %s', connection_host) On 2016/07/15 09:22:21, petrcermak wrote: > nit: s/host ip for name/IP for host name/ Done. https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode306 httpclient.py:306: connection_host = connection_ip On 2016/07/15 09:22:21, petrcermak wrote: > You can just set connection_host on line 301. No point in defining connection_ip > at all. We want to keep the original connection_host to do error reporting on line 304 https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode374 httpclient.py:374: real_dns_lookup: a function that resolves a host to an IP. On 2016/07/15 09:22:21, petrcermak wrote: > Remove this line Done. https://codereview.appspot.com/304120043/diff/40001/httpclient.py#newcode490 httpclient.py:490: http_archive, inject_script) On 2016/07/15 09:22:21, petrcermak wrote: > nit: These two arguments should now fit on the previous line. Done.
Sign in to reply to this message.
LGTM. Petr
Sign in to reply to this message.
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 75460ca0577b0cc1013e5d11ef0057a707fc81df (presubmit successful).
Sign in to reply to this message.
|
