Fix lp:1250154 1.16 compatibility EnvironmentGet

Fix lp:1250154 1.16 compatibility EnvironmentGet

In updateSecrets now we skip the rest of the checks
after we discover EnvironmentGet is not implemented
in the API server (when talking to an older, 1.16
server for example). This fixes all the CLI commands
that call NewAPIConnFromName to work against older
servers.

https://code.launchpad.net/~dimitern/juju-core/204-lp-1250154-updatesecrets-1.16-compat/+merge/196124

Requires: https://code.launchpad.net/~dimitern/juju-core/203-lp-1253628-upgrade-juju-1.16-compat/+merge/196118

(do not edit description out of merge proposal)

[dimitern, 2013-11-21 14:49:25]

Please take a look.

[rog, 2013-11-21 15:13:52]

LGTM with two minor suggestions below.

https://codereview.appspot.com/30330043/diff/1/juju/api.go
File juju/api.go (right):

https://codereview.appspot.com/30330043/diff/1/juju/api.go#newcode80
juju/api.go:80: if err != nil && params.IsNoSuchRequest(err) {
if params.IsNoSuchRequest(err) {
   ...
   return nil
}
if err != nil {
    return err
}

looks slightly better perhaps?

https://codereview.appspot.com/30330043/diff/1/juju/api.go#newcode83
juju/api.go:83: logger.Infof("running in 1.16 compatibility mode; skipping
checks for secrets")
s/Infof/Warningf/ ?
s/skipping checks for secrets/connection may fail if environment is just
bootstrapped/ ?

[dimitern, 2013-11-21 15:24:01]

Please take a look.

https://codereview.appspot.com/30330043/diff/1/juju/api.go
File juju/api.go (right):

https://codereview.appspot.com/30330043/diff/1/juju/api.go#newcode80
juju/api.go:80: if err != nil && params.IsNoSuchRequest(err) {
On 2013/11/21 15:13:53, rog wrote:
> if params.IsNoSuchRequest(err) {
>    ...
>    return nil
> }
> if err != nil {
>     return err
> }
> 
> looks slightly better perhaps?

Done.

https://codereview.appspot.com/30330043/diff/1/juju/api.go#newcode83
juju/api.go:83: logger.Infof("running in 1.16 compatibility mode; skipping
checks for secrets")
On 2013/11/21 15:13:53, rog wrote:
> s/Infof/Warningf/ ?
> s/skipping checks for secrets/connection may fail if environment is just
> bootstrapped/ ?

Done.