Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments. Please
Sign in
to add in-line comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1870)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Side by Side Diff: input/regression/midi/crescendo-single-unspecified-target.ly
Issue
302910043
:
Issue 4048: Improve crescendo performance with unspecified dynamics (Closed)
Patch Set: review response
Created 8 years, 8 months ago
Left:
Base
Patch Set 1: Add some regression tests
Patch Set 2: Represent dynamics as a piecewise linear function
Patch Set 3: Handle multiple (de)crescendi in depart-return groups
Patch Set 4: review response
Right:
Patch Set 1: Add some regression tests
Patch Set 2: Represent dynamics as a piecewise linear function
Patch Set 3: Handle multiple (de)crescendi in depart-return groups
Patch Set 4: review response
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Jump to:
input/regression/midi/crescendo-abutting.ly
input/regression/midi/crescendo-gap-compatible-target.ly
input/regression/midi/crescendo-return-crescendo.ly
input/regression/midi/crescendo-return-louder-target.ly
input/regression/midi/crescendo-return-softer-target.ly
input/regression/midi/crescendo-return-unspecified-target.ly
input/regression/midi/crescendo-single-compatible-target.ly
input/regression/midi/crescendo-single-unspecified-target.ly
input/regression/midi/decrescendo-multiple-compatible-target.ly
input/regression/midi/decrescendo-single-contrary-target.ly
lily/audio-item.cc
lily/dynamic-performer.cc
lily/include/audio-item.hh
lily/include/midi-item.hh
lily/midi-item.cc
lily/staff-performer.cc
View unified diff
|
Download patch
« no previous file with comments
|
« input/regression/midi/crescendo-single-compatible-target.ly
('k') |
input/regression/midi/decrescendo-multiple-compatible-target.ly »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
\version "2.19.44"
2
3
\header {
4
texidoc="If no explicit dynamic follows a crescendo, the dynamic
5
performer chooses a reasonable target dynamic."
6
}
7
8
\score {
9
{ c\mf\< c\! }
10
\midi {}
11
}
OLD
NEW
« no previous file with comments
|
« input/regression/midi/crescendo-single-compatible-target.ly
('k') |
input/regression/midi/decrescendo-multiple-compatible-target.ly »
('j') |
no next file with comments »
Issue 302910043: Issue 4048: Improve crescendo performance with unspecified dynamics (Closed)
Created 8 years, 9 months ago by Dan Eble
Modified 8 years, 8 months ago
Reviewers: ht
Base URL:
Comments: 30
Recent Issues
|
This issue
This is Rietveld
f62528b