ui/gtk3: Fix radio buttons on Property Panel

ui/gtk3: Fix radio buttons on Property Panel

Use gtk_container_remove() instead g_object_unref() because
if an widget has a parent, it's not destroyed and the signal is not
sent to the parent since the parent was destroyed.

R=shawn.p.huang@gmail.com

Committed: ceb6a9b47deaa898d8151606831669a7446ad382

[shawn.p.huang_gmail.com, 2016-09-06 03:59:03]

lgtm

<takao.fujiwara1@gmail.com>于2016年9月5日周一 下午11:25写道：

> Reviewers: shawn.p.huang_gmail.com,
>
> Description:
> ui/gtk3: Fix radio buttons on Property Panel
>
> Use gtk_container_remove() instead g_object_unref() because
> if an widget has a parent, it's not destroyed and the signal is not
> sent to the parent since the parent was destroyed.
>
> Please review this at https://codereview.appspot.com/302650043/
>
> Affected files (+6, -4 lines):
>    M ui/gtk3/propertypanel.vala
>
>
> Index: ui/gtk3/propertypanel.vala
> diff --git a/ui/gtk3/propertypanel.vala b/ui/gtk3/propertypanel.vala
> index
>
>
6d5fd81ef396afd61fe1dbffc7028759ec710b02..ea960b81e9c190439d6bcb8f83ce4f8cb234715b
> 100644
> --- a/ui/gtk3/propertypanel.vala
> +++ b/ui/gtk3/propertypanel.vala
> @@ -2,9 +2,9 @@
>    *
>    * ibus - The Input Bus
>    *
> - * Copyright(c) 2013-2015 Red Hat, Inc.
> + * Copyright(c) 2013-2016 Red Hat, Inc.
>    * Copyright(c) 2013-2015 Peng Huang <shawn.p.huang@gmail.com>
> - * Copyright(c) 2013-2015 Takao Fujiwara <takao.fujiwara1@gmail.com>
> + * Copyright(c) 2013-2016 Takao Fujiwara <takao.fujiwara1@gmail.com>
>    *
>    * This library is free software; you can redistribute it and/or
>    * modify it under the terms of the GNU Lesser General Public
> @@ -85,7 +85,7 @@ public class PropertyPanel : Gtk.Box {
>           debug("set_properties()\n");
>
>           foreach (var item in m_items)
> -            (item as Gtk.Widget).destroy();
> +            remove((item as Gtk.Widget));
>           m_items = {};
>
>           m_props = props;
> @@ -481,6 +481,8 @@ public class PropMenu : Gtk.Menu, IPropToolItem {
>
>       public override void destroy() {
>           m_parent_button = null;
> +        foreach (var item in m_items)
> +            remove((item as Gtk.Widget));
>           m_items = {};
>           base.destroy();
>       }
> @@ -739,7 +741,7 @@ public class PropMenuToolButton : PropToggleToolButton,
> IPropToolItem {
>           m_menu = new PropMenu(prop);
>           m_menu.deactivate.connect((m) =>
>                                     set_active(false));
> -        m_menu.property_activate.connect((w, k, s) =>
> +        m_menu.property_activate.connect((k, s) =>
>                                            property_activate(k, s));
>
>           base.set_property(prop);
>
>
>

[fujiwara, 2016-09-06 04:05:51]

Committed patchset #1 (id:1) manually as
ceb6a9b47deaa898d8151606831669a7446ad382 (presubmit successful).