Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480)

Issue 302090043: Add checking conflicts between CFF flavored fonts

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by trueroad
Modified:
3 years, 3 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4909/2: Add checking conflicts between CFF flavored fonts This commit adds checking conflicts between fonts which have same name in 'CFF' table but different name in 'name' table. Issue 4909/1: Add procedure `ly:get-cff-offset` This commit adds procedure `ly:get-cff-offset` which gets the offset of 'CFF' table for a font.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -1 line) Patch
M lily/open-type-font-scheme.cc View 2 chunks +159 lines, -0 lines 0 comments Download
M scm/framework-ps.scm View 1 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 4
lemzwerg
LGTM. https://codereview.appspot.com/302090043/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): https://codereview.appspot.com/302090043/diff/1/scm/framework-ps.scm#newcode259 scm/framework-ps.scm:259: (_ "The same CFF font `~a' has been ...
3 years, 3 months ago (2016-06-28 16:36:38 UTC) #1
trueroad
Fix messages
3 years, 3 months ago (2016-06-28 22:03:43 UTC) #2
trueroad
Thank you for your reviewing. https://codereview.appspot.com/302090043/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): https://codereview.appspot.com/302090043/diff/1/scm/framework-ps.scm#newcode259 scm/framework-ps.scm:259: (_ "The same CFF ...
3 years, 3 months ago (2016-06-28 22:05:23 UTC) #3
trueroad
3 years, 3 months ago (2016-07-04 12:59:50 UTC) #4
I've pushed to staging.

Issue 4909/2: Add checking conflicts between CFF flavored fonts
commit eda66de049d33031a3230dfbf5735399bf2c1d60

Issue 4909/1: Add procedure `ly:get-cff-offset`
commit 2291f61e0d7acd637cd003c8c50cc82af4336273
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b