Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1505)

Issue 302020043: Fold Slur_proto_engraver into Slur_engraver

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by dak
Modified:
3 years, 2 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fold Slur_proto_engraver into Slur_engraver A symmetrical common base class to both Slur_engraver and Phrasing_slur_engraver seems like an unnecessary complication. Instead, Phrasing_slur_engraver can just be derived from Slur_engraver . Also contains commits: Restructure slur engravers Replaces data members specific to derived classes of Slur_proto_engraver with virtual functions. internal_make_grob: Remove unused `name' argument

Patch Set 1 #

Patch Set 2 : Add lily/include/engraver.hh, massage include files #

Patch Set 3 : While we are at it... Some more polish. #

Patch Set 4 : Rebase on current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -516 lines) Patch
M lily/engraver.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M lily/engraver-scheme.cc View 1 chunk +0 lines, -1 line 0 comments Download
M lily/include/engraver.hh View 3 chunks +7 lines, -7 lines 0 comments Download
A + lily/include/slur-engraver.hh View 1 2 3 4 chunks +11 lines, -19 lines 0 comments Download
D lily/include/slur-proto-engraver.hh View 1 2 3 1 chunk +0 lines, -89 lines 0 comments Download
M lily/include/translator.hh View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M lily/new-fingering-engraver.cc View 1 chunk +1 line, -3 lines 0 comments Download
M lily/phrasing-slur-engraver.cc View 1 2 3 1 chunk +36 lines, -20 lines 0 comments Download
M lily/slur-engraver.cc View 1 2 3 2 chunks +332 lines, -17 lines 0 comments Download
D lily/slur-proto-engraver.cc View 1 chunk +0 lines, -352 lines 0 comments Download

Messages

Total messages: 3
dak
Add lily/include/engraver.hh, massage include files
3 years, 2 months ago (2016-06-21 12:30:55 UTC) #1
dak
While we are at it... Some more polish.
3 years, 2 months ago (2016-06-22 16:24:53 UTC) #2
dak
3 years, 2 months ago (2016-06-23 17:29:42 UTC) #3
Rebase on current master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b