Issue 301760043: client/gtk2: Fix ibus_set_display() for Wayland

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 301760043: client/gtk2: Fix ibus_set_display() for Wayland (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 5 months ago by fujiwara

Modified:
8 years, 5 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

client/gtk2: Fix SEGV with Wayland display Delete gdk_display_get_name() in GTK clients because ibus-daemon does not use gdk_display_get_name(). GdkX11Dislay and GdkX11Window does not work with Wayland. BUG=https://github.com/ibus/ibus/issues/1859 R=Shawn.P.Huang@gmail.com Committed: 3ef21fef0135f7b4fe9611d201f15611734f6c51

Patch Set 1 #

Patch Set 2 : Updated with https://github.com/ibus/ibus/issues/1859#issuecomment-221600165 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	client/gtk2/ibusimcontext.c	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
	M	setup/main.py	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fujiwara

On 2016/05/25 23:54:19, Peng wrote: > On 2016/05/25 10:35:38, fujiwara wrote: > > lgtm I ...

8 years, 5 months ago (2016-05-27 02:32:55 UTC) #3

Peng

On 2016/05/27 02:32:55, fujiwara wrote: > On 2016/05/25 23:54:19, Peng wrote: > > On 2016/05/25 ...

8 years, 5 months ago (2016-06-02 11:03:51 UTC) #4

fujiwara

8 years, 5 months ago (2016-06-03 02:52:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3ef21fef0135f7b4fe9611d201f15611734f6c51 (presubmit successful).

Expand All Messages | Collapse All Messages