Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1096)

Issue 3005: patch for bug 1878 - turn Py_TPFLAGS_HAVE_VERSION_TAG off when not building the core (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by GvR
Modified:
8 years, 3 months ago
Reviewers:
Benjamin
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/
Visibility:
Public.

Description

r65874.

Patch Set 1 #

Patch Set 2 : clear trailing whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
Include/object.h View 1 5 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 2
GvR
Please review this, or I'll just submit it in an hour or so...
9 years, 3 months ago (2008-08-19 19:27:46 UTC) #1
Benjamin
9 years, 3 months ago (2008-08-19 19:34:26 UTC) #2
Looks basically fine to me.

http://codereview.appspot.com/3005/diff/1/2
File Include/object.h (right):

http://codereview.appspot.com/3005/diff/1/2#newcode531
Line 531: Py_TPFLAGS_HAVE_VERSION_TAG; outside the core, it doesn't.)
Perhaps you should explain why somewhere.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4